Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't check for updates in demo mode #163

Merged
merged 5 commits into from
Oct 29, 2024
Merged

Don't check for updates in demo mode #163

merged 5 commits into from
Oct 29, 2024

Conversation

danirabbit
Copy link
Member

No description provided.

@danirabbit danirabbit requested a review from a team October 8, 2024 17:42
@danirabbit danirabbit requested a review from ryonakano October 18, 2024 22:40
ryonakano
ryonakano reviewed Oct 19, 2024
View reviewed changes
Copy link
Contributor

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, we're also missing src/Utils/SessionUtils.vala in meson.build. That's why the build still failing.

@danirabbit danirabbit requested a review from ryonakano October 23, 2024 18:24
@danirabbit
Copy link
Member Author

@ryonakano sorry about the sloppy branch. Should be fixed now

ryonakano
ryonakano approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine and makes sense.

This would be a separated PR, but Refresh button in the System plug now does nothing because of this change. Maybe we need to add a new definition to PkUtils.CurrentState and use it for the sensitivity of the button.

Screenshot from 2024-10-24 20-05-28

@danirabbit
Copy link
Member Author

@ryonakano Ah yeah okay, added also a check for force so that the refresh button should still work. Then we can consider doing something different with the UI in demo mode separately :)

@danirabbit
Copy link
Member Author

Filed elementary/switchboard-plug-about#341

ryonakano
ryonakano approved these changes Oct 27, 2024
View reviewed changes
Copy link
Contributor

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed clicking the refresh button checks for update in the demo mode.

@danirabbit danirabbit merged commit c5fd1da into main Oct 29, 2024
4 checks passed
@danirabbit danirabbit deleted the danirabbit/utils-demomode branch October 29, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryonakano ryonakano ryonakano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danirabbit @ryonakano @zeebok