Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drivers v2 (with support for device grouping) #141

Merged
merged 24 commits into from
May 30, 2024
Merged

Drivers v2 (with support for device grouping) #141

merged 24 commits into from
May 30, 2024

Conversation

leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Feb 18, 2024

As suggested this implements allowing to group drivers by device.
Since this required quite a few more steps where different cli outputs have to be parsed, compared, compared again and then double checked, this PR should be tested thoroughly. I've tested with a nvidia card and there it works however I don't know how it will behave with two or more devices etc.

elementary/switchboard-plug-about#309

@Conan-Kudo
Copy link

This also needs to be able to be disabled since it only works in Ubuntu (or ported to use AppStream driver definitions through PackageKit).

@leolost2605
Copy link
Member Author

leolost2605 commented May 15, 2024

It can be disabled via a meson option now (just like it was in appcenter) and is enabled by default
Also if ubuntu drivers can't be found it will just soft fail

Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to test this really well, but the code seems good

@leolost2605
Copy link
Member Author

I'd say let's merge this to get more testing in :)

@danirabbit danirabbit merged commit 9fcaf5c into master May 30, 2024
4 checks passed
@danirabbit danirabbit deleted the drivers-v2 branch May 30, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants