Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SystemUpdate: optionally update automatically #118

Merged
merged 6 commits into from
Jan 29, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Jan 25, 2024

Fixes #52

@danirabbit danirabbit marked this pull request as ready for review January 25, 2024 20:24
@leolost2605
Copy link
Member

Also just wondering whether we should go the GNOME route and have a tick box with "Install pending software updates" in the shutdown dialog? This would allow for an update and shutdown behavior without user interaction which on windows is quite useful to me... on the other hand it might lead to users just never installing updates..? Although I think that's unlikely?

@danirabbit
Copy link
Member Author

@leolost2605 sorry I'm not sure I understand. Are you saying have a checkbox to opt out of installing pending updates?

@leolost2605
Copy link
Member

@danirabbit yup:

(sry for the quality, was the best screenshot i could find, i currently don't have a gnome install lying around)
shutdown with update

Also here if you click shutdown it will first restart into updating and then shutdown without user interaction.

On windows the shutdown menu after an update has the options restart, restart and update, shutdown, shutdown and update

I'm not quite sure we really need this since updates here take not that long and shutdown always works (it doesn't first update and then shutdown). But for example if I just need to quickly restart and don't want to update anything this might be useful. Or if I go to bed for example I can shutdown and it will automatically install the updates before actually shutting down so in the morning when i fire up my pc it's ready to go and doesn't boot right into the update process.

@danirabbit
Copy link
Member Author

@leolost2605 those sound like quite a bit more complicated behaviors than what I was going for here. Could we look at additional features in follow-up branches?

Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leolost2605
Copy link
Member

@leolost2605 those sound like quite a bit more complicated behaviors than what I was going for here. Could we look at additional features in follow-up branches?

@danirabbit yeah of course I was just abusing this PR to get design feedback for that :)
Also this would have to be implemented in the session wingpanel indicatior I think (where the end session dialog is)

@danirabbit danirabbit merged commit a584677 into master Jan 29, 2024
4 checks passed
@danirabbit danirabbit deleted the danirabbit/automatic-updates branch January 29, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow apt updates to be automatically installed
2 participants