Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set LANG variable on startup #843

Merged
merged 2 commits into from
Oct 20, 2024
Merged

Set LANG variable on startup #843

merged 2 commits into from
Oct 20, 2024

Conversation

davidmhewitt
Copy link
Member

@davidmhewitt davidmhewitt commented Oct 19, 2024

Fixes #775

gettext doesn't give us translations if LANG is set to C.UTF-8 (which it is initially on the ISO)

If we initially set this to English, gettext initializes properly and then we can correctly change the language at runtime with the LANGUAGE variable after that.

Copy link
Contributor

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build the ISO and confirmed the issue now fixed finally! Thank you very much for your investigation ❤️

VirtualBox_test_19_10_2024_15_41_40

VirtualBox_test_19_10_2024_15_43_36

@danirabbit danirabbit enabled auto-merge (squash) October 20, 2024 03:34
@danirabbit danirabbit merged commit 81d4a9d into main Oct 20, 2024
5 checks passed
@danirabbit danirabbit deleted the david__set_lang_env branch October 20, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installer is not localized
3 participants