New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HostnameValidatorTest: cleanup, comments, more tests #826

Merged

meisenzahl merged 2 commits into main from danirabbit/hostnametest-cleanup

Oct 3, 2024

Member

danirabbit commented Oct 2, 2024

HostnameValidator.vala:

Add comments inline and separate lines so we know exactly what each line tests for
Use has_prefix and has_suffix

HostnameValidatorTest:

Give this test a unique name for CI
Make the test one file
Fix path syntax in meson
Add comments so we know what each line tests for
Make sure we test for all of the things that the function should be checking, notably empty hostname and a super long hostname with otherwise short labelsni

danirabbit added 2 commits

October 2, 2024 15:03


          HostnameValidatorTest: cleanup, comments, more tests

c8b8099


          More compact test

7361ee4

danirabbit requested a review from a team

October 2, 2024 22:10

meisenzahl approved these changes

View reviewed changes

Member

meisenzahl left a comment

Looks good! Thanks for the cleanup 😄

meisenzahl merged commit 6337c27 into main

5 checks passed

meisenzahl deleted the danirabbit/hostnametest-cleanup branch

October 3, 2024 14:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet