Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send battery notification instead of infobar #821

Merged
merged 8 commits into from
Oct 8, 2024

Conversation

danirabbit
Copy link
Member

Since we have notifications in the installer session now. Doesn't block UI and fixes a deprecation warning

@danirabbit danirabbit marked this pull request as ready for review October 2, 2024 17:26
@danirabbit danirabbit requested a review from a team October 2, 2024 17:26
@ryonakano
Copy link
Contributor

Tested on my old MacBook Air, and confirmed the notification appears when unplugged and disappears when plugged.

One thing I'm concerning is that the notification body may be ellipsized in some languages, although users still should be able to understand what they should do from the notification title:

image

@danirabbit
Copy link
Member Author

@ryonakano made the body text a lot shorter. I suppose we probably need to open an issue in Notifications about how to handle longer strings

@ryonakano
Copy link
Contributor

@danirabbit Thanks for the fix. Handling notifications with long text seems to be already reported at elementary/notifications#66 so I approve this now :)

@danirabbit danirabbit enabled auto-merge (squash) October 8, 2024 16:48
@danirabbit danirabbit merged commit deae7d0 into main Oct 8, 2024
5 checks passed
@danirabbit danirabbit deleted the danirabbit/battery-notification branch October 8, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants