Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare support for other backends #737

Merged
merged 33 commits into from
Oct 3, 2024
Merged

Prepare support for other backends #737

merged 33 commits into from
Oct 3, 2024
+769 −614

Conversation

meisenzahl
Copy link
Member

This serves as preparation to be able to support other installer backends.

@meisenzahl
DBusStructures: Add new file system enum and partition usage struct
d43e49a
@meisenzahl
DBusStructures: Add to_string method to FileSystem enum
ff2b6d0
@meisenzahl
Update file system types to use InstallerDaemon
5853498 
instead of Distinst
@meisenzahl
Daemon: Convert file system and partition usage to common format
8c137fe
@meisenzahl
Add PartitionTable enum and update
3e041ce 
bootloader_detect method
@meisenzahl
Add new enums and struct for InstallerDaemon and update flags in Daem…
3a2ed8d 
…on and ProgressView
@meisenzahl
Refactor to_common_usage_bootloader method in Daemon class
c1e4fa9
@meisenzahl
Add InstallerDaemon.LogLevel and InstallerDaemon.Error to InstallerDa…
7cdde6a 
…emon.Daemon signals
@meisenzahl
Utils: Remove distinst specific code
08a0147
@meisenzahl
Refactor file common/DBusStructures.vala to handle FileSystem.NONE ca…
dd09a4b 
…se in a default statement.
@meisenzahl
Remove distinst_dep from gui_dependencies
82c20cd
@meisenzahl
Add support for Distinst installer backend in
2d382d2 
daemon
@meisenzahl
Satisfy linter
400d567
@meisenzahl meisenzahl mentioned this pull request Nov 9, 2023
Draft
@danirabbit danirabbit mentioned this pull request Sep 11, 2024
Merged
@meisenzahl meisenzahl marked this pull request as ready for review September 26, 2024 10:30
@meisenzahl
Copy link
Member Author

meisenzahl commented Sep 26, 2024 •
edited
Loading

I successfully tested this with elementaryos-8.0-daily.20240925.iso.

Steps to test this
  • Try Demo Mode
  • Add # to deb cdrom in /etc/apt/sources.list
  • sudo apt update
  • sudo apt install git
  • git clone https://github.com/elementary/installer
  • cd installer
  • git checkout prepare-backends
  • sudo apt build-dep io.elementary.installer
  • meson build --prefix=/usr
  • ninja -C build
  • sudo ninja -C build install
  • sudo systemctl daemon-reload
  • sudo systemctl restart io.elementary.InstallerDaemon
  • Log Out
  • Install as usual

@meisenzahl meisenzahl requested a review from a team September 26, 2024 10:33
danirabbit
danirabbit reviewed Oct 1, 2024
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions :)

common/DBusStructures.vala Show resolved Hide resolved
src/Utils.vala Outdated Show resolved Hide resolved
danirabbit
danirabbit requested changes Oct 1, 2024
View reviewed changes
src/HostnameValidator.vala Outdated Show resolved Hide resolved
src/HostnameValidator.vala Outdated Show resolved Hide resolved
src/HostnameValidator.vala Outdated Show resolved Hide resolved
@danirabbit
Copy link
Member

@meisenzahl Would it be too much to ask to propose the hostname validator bit as a separate branch? I think that's probably worth its own commit

@meisenzahl meisenzahl mentioned this pull request Oct 2, 2024
Merged
danirabbit
danirabbit approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I can confirm that the new DistinstBackend file is basically what was in Daemon plus a few methods to convert from Distinst structs to our internal structs

@meisenzahl meisenzahl merged commit c35927a into main Oct 3, 2024
5 checks passed
@meisenzahl meisenzahl deleted the prepare-backends branch October 3, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Distro-agnostic Pantheon
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meisenzahl @danirabbit