-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rust mime #983
Add Rust mime #983
Conversation
Those small sizes have the Rust logo a lot blurry, could you try to make it fit the pixel-grid? |
@lainsce, I tried to edit the logo to fit into the grid but I couldn't improve it that much. Rust logo is really complex. Do you think we can proceed this PR with just the 48, 64, and 128 sizes? I've noticed that there are some other icons that are also not available at smaller sizes. |
Maybe just 48 and 128 I guess, should cover the divisions pretty well (128 divides to 64 divides to 32 / 48 divides to 24), but try to make those two have the pixel-grid as much as possible. A followup PR maybe from someone on the UX team may follow :P |
Ok, so I deleted the smaller sizes and improved the fit to the grid a bit more. Rust logo is really complex, so it's not perfect. I did the same for the R logo (#987), although I maintained the 32 version there because I think it is looking good. Thanks again for the tips @lainsce! In order to get a review from the UX team should I do something, or just wait? I know they have a lot on their plates right now, so I won't tag anyone them here. There are some other mimetype icons that I'd like to add, but I prefer to get those right first to learn how to do this right. |
Just keep doing PRs and the UX team will go one by one later. |
Rust's art license allows modifications to the artwork. I'd suggest making a second, simplified version of the logo that looks good at the smaller sizes. For example, you could remove the four small holes and make the outline a smooth circle with a radius that looks similar to the logo with teeth (radius with no teeth + tooth length/2). Then you could use one version for the larger sizes and another for the smaller ones. |
@danrabbit Has this PR any chance? It has been outstanding a fair while. |
Hey thanks for your contribution! I just responded to the original issue report. Sorry I know it's not what you're hoping to hear!
|
Closes #979