-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add window spread for an app #1833
Conversation
Currently it minimizes and then unminimizes other windows but since that's done while activating the overview it can be a bit overwhelming and look a bit flickery. Another option would be to just hide which doesn't look too bad and maybe even a bit better? Opinions/any other ideas @elementary/ux ? With just hiding: RecApp-2024-01-20-23.23.06.webmWith minimizing/unminizing: RecApp-2024-01-20-23.25.09.webm |
For testing one can use elementary/dock#210 |
Yeah I agree the minimize animation is heavy. Is there no animation on hide? I'm sure it's outside of the scope of this branch but perhaps we should make sure there's a crossfade or something for hide and maybe speed up this window spread animation a little bit. But otherwise, this is great! |
Should be easy enough but for some reason the WindowActors become just grey rectangles instead of going transparent when setting opacity to 0. Not quite sure what to do here 🤷 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving on behalf of UX but requested Leo for code review since he's more active in this repo than I am
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is going to be used by dock when more than one window is open for an app and the app icon is clicked on.
Uses the WindowOverview but with only the windows that belong to the specific app. Once the dock is properly integrated it will stay as well and don't go away.
Also opinions in general on this? An alternative would be something more classical like the alt tab switcher but with window previews over the dock icon but I like this a bit more and it is as far as I understood it what's meant in #1377.
Mostly fixes #1377 (probably together with #1817, alternatively that can be absorbed here with this handling deciding between focus for one or spread for two or more but I think a window list in the context menu would still be useful in the dock)