Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Launching from Indicator #66

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Allow Launching from Indicator #66

merged 1 commit into from
Oct 13, 2021

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Oct 12, 2021

Fixes #3
Fixes #39

Remove the NM dispatch script, because the panel is supposed to launch capnet.

We don't need to do a connectivity check or have the force flag because there are only two cases where Capnet would be launched:

  1. We already detected a portal in the network indicator
  2. The user is manually launching capnet from Terminal, in which case it doesn't make sense to bail even if we're connected

@cassidyjames
Copy link
Contributor

cassidyjames commented Oct 13, 2021

Is it possible we had the check for captive portal here as well because NM could incorrectly detect a captive network, but then by the time we were launching capnet-assist it had resolved to not be captive? I think I'm fine to merge this once I test it a bit, but it's probably worth testing this for a while in a variety of network conditions before releasing to make sure we don't suddenly get a lot more false positives.

@danirabbit
Copy link
Member Author

danirabbit commented Oct 13, 2021

Yeah I think probably the real solution to that would be to add a network monitor and connect to changes in the network state (basically exactly what we do in the indicator). That would fix #5 and or #4

Copy link
Contributor

@cassidyjames cassidyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected here.

@cassidyjames cassidyjames merged commit 99fec1a into master Oct 13, 2021
@cassidyjames cassidyjames deleted the indicator-launch branch October 13, 2021 22:18
@ryonakano ryonakano mentioned this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

90captive_portal_test: drop insecure PATH elements Remove 90captive_portal_test
2 participants