Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 44 #83

Merged
merged 12 commits into from
Apr 11, 2023
Merged

Bump to 44 #83

merged 12 commits into from
Apr 11, 2023

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Mar 6, 2023

Related discussion at #82

Fixes #53
Fixes #78
Fixes #90
Fixes #92

Sync with flathub/org.gnome.Epiphany@5c28b6a

@danirabbit danirabbit requested a review from a team April 2, 2023 17:24
@danirabbit danirabbit marked this pull request as ready for review April 2, 2023 17:24
@stan-janssen
Copy link

stan-janssen commented Apr 2, 2023

I’ve been trying this version of Web for the past few days, and I think there might be a few issues. I tried to make a screen recording of it, but it did not really come across. I’m comparing three versions: the AppCenter version (the current, ‘old’ version), the Pull Request version (this version) and the Flathub version, which is the current Gnome version.

  1. The browser dialogs seem to be not styled properly. This happens on both the Pull Request version and the Flathub version. Can others reproduce this?

browser-dialog

  1. Videos in a <video> tag don't seem to play. They do play on the current AppCenter version and on the current Flathub version. Can anyone else reproduce this? For instance, the videos on this Github.com pull request: Make the notifications move out of the way when menus are opened wingpanel#481

  2. On the Pull Request version and on the Flathub version, scrolling has... changed? Perhaps this is intentional and it’s not neccessarily a blocking issue. I use a Starbook MK V and on the current AppCenter version, the scrolling intertia is the same between Web and the other elementaryOS apps like Mail and Code. On the new version, the inertia is much "stiffer": it breaks much harder after you flick and stops scrolling sooner, if that makes sense. I'm not sure if anyone else has one of these laptops or can reproduce this on a different system.

I'd be more than happy to help try to figure these things out properly by the way. Let me know if I can do anything to help!

@stan-janssen
Copy link

If it helps, this is how I’m starting these different versions (after installing them):

  • AppCenter: flatpak run --system org.gnome.Epiphany/x86_64/stable
  • Pull Request: flatpak run --user org.gnome.Epiphany/x86_64/master
  • Flatub: flatpak run --user org.gnome.Epiphany/x86_64/stable

@danirabbit
Copy link
Member Author

@stan-janssen

  1. Can you open an issue report about this on elementary/stylesheet? I'm guessing this is Adw.Dialog. It could be styled better, but I'm not sure I would consider this release blocking
  2. I can confirm video playback isn't working here. My guess is this is due to missing GL platform or something. I'll investigate :)
  3. I think scrolling is changing in WebKitGTK. Since this also occurs in the Flathub version it would be good to report that upstream in the Ephy gitlab

@mcatanzaro
Copy link

I think scrolling is changing in WebKitGTK. Since this also occurs in the Flathub version it would be good to report that upstream in the Ephy gitlab

For problems with scrolling, use WebKit Bugzilla, WebKitGTK component

@stan-janssen
Copy link

  1. Can you open an issue report about this on elementary/stylesheet? I'm guessing this is Adw.Dialog. It could be styled better, but I'm not sure I would consider this release blocking

I agree that it’s not a blocking issue. The dialog still works fine :-)

Here’s the issue on this: elementary/stylesheet#1251

@stan-janssen
Copy link

stan-janssen commented Apr 3, 2023

Another non-blocking thing that would be nice to get back sometime is the two-finger gestures for back/forward navigation that are no longer there in the new version.

@mcatanzaro
Copy link

Another non-blocking thing that would be nice to get back sometime is the two-finger gestures for back/forward navigation that are no longer there in the new version.

That's unexpected. 🙀️

@danirabbit danirabbit mentioned this pull request Apr 5, 2023
@danirabbit

This comment was marked as resolved.

@Marukesu

This comment was marked as resolved.

@danirabbit

This comment was marked as resolved.

@danirabbit

This comment was marked as resolved.

@danirabbit
Copy link
Member Author

@stan-janssen we've resolved the video playback issue in the 7.2 runtime :)

@danirabbit
Copy link
Member Author

@stan-janssen is there anything else holding this back in your opinion? :)

@stan-janssen
Copy link

@danirabbit No, I don't think so :-) The few cosmetics can be fixed later I think. It's your call! 🚀

@danirabbit danirabbit merged commit 9eaa5bb into main Apr 11, 2023
@danirabbit danirabbit deleted the 44 branch April 11, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants