Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create app icon #7

Merged
merged 5 commits into from
Jul 20, 2024
Merged

Create app icon #7

merged 5 commits into from
Jul 20, 2024

Conversation

danirabbit
Copy link
Member

Make sure we're supplying an app icon instead of using non-fd.o icon name

@danirabbit danirabbit requested a review from a team July 19, 2024 17:43
ryonakano
ryonakano reviewed Jul 19, 2024
View reviewed changes
Copy link
Contributor

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need gnome.post_install(gtk_update_icon_cache: true) in meson.build, otherwise the new icon is not shown.

@danirabbit danirabbit requested a review from ryonakano July 20, 2024 01:49
@ryonakano ryonakano merged commit 224ee33 into main Jul 20, 2024
4 checks passed
@ryonakano ryonakano deleted the danirabbit/icon branch July 20, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryonakano ryonakano ryonakano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @ryonakano