BtScan: rewrite as granite.messagedialog, gtk4 prep #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
danirabbit
commented
Jul 19, 2024
danirabbit
commented
- There doesn't seem to be a good reason to hold a ref to the application here?
- Use Granite.MessageDialog to save ourselves some layout pains
- Use modern functions of scrolled window instead of hardcoding a height
- Make sure dialog is resizable
- Code style
- Remove redundant list header
ryonakano
reviewed
Jul 20, 2024
| * You should have received a copy of the GNU General Public License | ||
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| /* | ||
| * SPDX-License-Identifier: LGPL-3.0-or-later |
There was a problem hiding this comment.
Suggested change
| * SPDX-License-Identifier: LGPL-3.0-or-later | |
| * SPDX-License-Identifier: GPL-3.0-or-later |
Because the previous (deleted) comments says GNU General Public License, and plus this is not a library.
|
Also, the width of the frame is changed with this branch; now we have a wider left margin with the frame. Is this intentional? Before
After
|
…4prep Conflicts: src/Dialog/BtScan.vala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.