Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy bluetooth daemon from panel indicator #1

Merged
merged 9 commits into from
Jul 18, 2024
Merged

Copy bluetooth daemon from panel indicator #1

merged 9 commits into from
Jul 18, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Jul 17, 2024 •
edited
Loading

@danirabbit danirabbit requested a review from ryonakano July 17, 2024 16:55
@danirabbit danirabbit marked this pull request as ready for review July 17, 2024 16:55
ryonakano
ryonakano reviewed Jul 17, 2024
View reviewed changes
Copy link
Contributor

@ryonakano ryonakano left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your quick work! Leaving a few tiny comments.

.github/workflows/gettext.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/gettext.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@danirabbit danirabbit requested a review from ryonakano July 18, 2024 16:59
ryonakano
ryonakano previously approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go 🚀

@ryonakano ryonakano dismissed their stale review July 18, 2024 21:55

Need to fix README

ryonakano
ryonakano reviewed Jul 18, 2024
View reviewed changes
README.md Show resolved Hide resolved
ryonakano
ryonakano approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the dependencies list in README.md was not parsed as a list. LGTM!

@ryonakano ryonakano merged commit 7d9cf35 into main Jul 18, 2024
4 checks passed
@ryonakano ryonakano deleted the danirabbit/rest-of-the-owl branch July 18, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryonakano ryonakano ryonakano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate io.elementary.bluetooth source code into another repository
2 participants
@danirabbit @ryonakano