Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First batch: remove deprecated calls on MatrixClient #28207

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

First batch: remove deprecated calls on MatrixClient #28207

wants to merge 13 commits into from

Conversation

florianduros
Copy link
Member

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Task #26922
First batch of removing/migrating the deprecated calls on MatrixClient

@florianduros florianduros mentioned this pull request Oct 16, 2024
Open
@florianduros florianduros added the T-Task Tasks for the team like planning label Oct 16, 2024
@florianduros florianduros marked this pull request as ready for review October 16, 2024 14:47
@florianduros florianduros requested review from a team as code owners October 16, 2024 14:47
@t3chguy t3chguy requested a review from a team as a code owner October 17, 2024 08:11
@dbkr
Copy link
Member

dbkr commented Oct 17, 2024

I'm not sure github has done the right thing here :/ It's showing the react-sdk absorbing changeset as the diff.

@t3chguy
Copy link
Member

t3chguy commented Oct 17, 2024

Resolving conflicts might fix it, or it might prefer a rebase

@florianduros
Remove initCrypto mocking
19d5588
@florianduros
Remove MatrixClient.downloadKeys mocking
22c8655
@florianduros
Remove MatrixClient.getStoredDevice mocking
8915cd9
@florianduros
Replace MatrixClient.setGlobalBlacklistUnverifiedDevices by `Matrix…
cab8b8a 
…Client.CryptoApi.globalBlacklistUnverifiedDevices`
@florianduros
Remove MatrixClient.getStoredCrossSigningForUser mocking
585a649
@florianduros
Replace MatrixClient.legacyDeviceVerification by `MatrixClient.Cryp…
f12761c 
…toApi.requestDeviceVerification`
@florianduros
Remove MatrixClient.isCrossSigningReady mock
90fcb69
@florianduros
Replace MatrixClient.bootstrapCrossSigning by `MatrixClient.getCryp…
4f35b8f 
…to.bootstrapCrossSigning`
@florianduros
Replace MatrixClient.getCryptoTrustCrossSignedDevices by `MatrixCli…
25fa667 
…ent.getCrypto.getTrustCrossSignedDevices`
@florianduros
Replace MatrixClient.hasSecretStorageKey by `MatrixClient.SecretSto…
ed290b3 
…rage.hasKey`
@florianduros
Replace MatrixClient.getDefaultSecretStorageKeyId by `MatrixClient.…
c54f038 
…SecretStorage.getDefaultKeyId`
@florianduros
Remove MatrixClient.encryptAndSendToDevices call
511a70b
@florianduros florianduros force-pushed the florianduros/rip-out-legacy-crypto/1-remove-deprecated-call-client branch from 3d00557 to 511a70b Compare October 17, 2024 12:36
@florianduros
Merge branch 'develop' into florianduros/rip-out-legacy-crypto/1-remo…
8904b28 
…ve-deprecated-call-client

# Conflicts:
#	test/unit-tests/components/structures/MatrixChat-test.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

@BillCarsonFr BillCarsonFr Awaiting requested review from BillCarsonFr BillCarsonFr is a code owner automatically assigned from element-hq/element-crypto-web-reviewers

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from element-hq/element-web-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@florianduros @dbkr @t3chguy