Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: prevent Electron versions that are in use by some window from being removed #1395

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

feat: prevent Electron versions that are in use by some window from being removed #1395

wants to merge 8 commits into from
+331 −28

Commits on Sep 8, 2023

  1. feat: prevent Electron versions that are in use by some window from b… 

    …eing removed
    @erikian
    erikian committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    d19082f View commit details
    Browse the repository at this point in the history

  2. refactor: update getVersionLock implementation

    @erikian
    erikian committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    9aa66bb View commit details
    Browse the repository at this point in the history

  3. refactor: return only the version names from getActiveVersions

    @erikian
    erikian committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    d70f7f9 View commit details
    Browse the repository at this point in the history

  4. refactor: use a boolean instead of the Lock object

    @erikian
    erikian committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    6e6c27e View commit details
    Browse the repository at this point in the history

  5. refactor: use the broadcast channel to update the currently active ve… 

    …rsions
    @erikian
    erikian committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    b63bfe6 View commit details
    Browse the repository at this point in the history

  6. test: mock navigator.locks and fix existing tests

    @erikian
    erikian committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    03851f5 View commit details
    Browse the repository at this point in the history

  7. test: update the mock to handle exclusive locks

    @erikian
    erikian committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    666cada View commit details
    Browse the repository at this point in the history

  8. feat: get a lock when downloading / removing a version

    @erikian
    erikian committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    fd6d0f4 View commit details
    Browse the repository at this point in the history