Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate mainline changes #79

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Integrate mainline changes #79

wants to merge 14 commits into from

Conversation

electrified
Copy link
Owner

No description provided.

@electrified
Updated version of driver from https://bugzilla.kernel.org/show_bug.c…
6a9a8a2 
…gi\?id\=204807\#c128
@electrified
v2 as sent to LKML. See https://lore.kernel.org/all/20211006222502.64…
7722079 
…[email protected]/
@electrified
v3 as sent to LKML. See https://lore.kernel.org/all/20211010095216.25…
7121e03 
…[email protected]/
@electrified
v4 of driver as provided to LKML
3eeb3fe
@electrified
v5 of the patch as sent to LKML
9313d10
@electrified
v6 of patch sent to LKML
293b6df
@electrified
v7 of patch see https://lore.kernel.org/all/20211015055808.327453-3-p…
73252df 
…[email protected]/
@electrified
v8 changes, Fix codestyle in defines and comments, Call mutex_lock in…
4e7ef57 
…side of functions.
@electrified
v9 Fix memory leaks in asus_wmi_*().
81e0f57
@electrified
Changes in v10:
0f048ae 
- Use long for sensor values.
- Remove unrequired linux/hwmon-sysfs.h
- Change code style in error status return.
- Remove unuses wmi.buffer and fix type of source.
@electrified
Integrate buffer overflow fix
0c85c92 
Original commit message:
Smatch detects this array overflow:

    drivers/hwmon/asus_wmi_sensors.c:569 asus_wmi_configure_sensor_setup()
    error: buffer overflow 'hwmon_attributes' 8 <= 9

The hwmon_attributes[] array should have "hwmon_max" so that it gets
larger when more attributes are added.
@electrified
Add ROG STRIX B450-F GAMING II - see https://lore.kernel.org/all/2022…
2e66778 
…[email protected]/
@electrified
Update readme to include details of upstreaming
3119f2f
@spiffeeroo
Copy link

Crosshair VI Hero motherboard (non WiFi) sensor does not work with the version mainlined in kernel 5.17. The master version used in the AUR works with Crosshair VI Hero motherboard. The current master version refers to motherboard as "CROSSHAIR VI HERO" whereas the 5.17 mainlined version uses "ROG CROSSHAIR VI HERO".

# dmidecode -t baseboard                                                             ツ 
# dmidecode 3.3
Getting SMBIOS data from sysfs.
SMBIOS 3.2.0 present.

Handle 0x0002, DMI type 2, 15 bytes
Base Board Information
        Manufacturer: ASUSTeK COMPUTER INC.
        Product Name: CROSSHAIR VI HERO
        Version: Rev 1.xx
        Serial Number: <redacted>
        Asset Tag: Default string
        Features:
                Board is a hosting board
                Board is replaceable
        Location In Chassis: Default string
        Chassis Handle: 0x0003
        Type: Motherboard
        Contained Object Handles: 0

Handle 0x0025, DMI type 10, 6 bytes
On Board Device Information
        Type: Video
        Status: Enabled
        Description:    To Be Filled By O.E.M.

Handle 0x0029, DMI type 41, 11 bytes
Onboard Device
        Reference Designation:  Onboard IGD
        Type: Video
        Status: Enabled
        Type Instance: 1
        Bus Address: 0000:00:02.0

Handle 0x002A, DMI type 41, 11 bytes
Onboard Device
        Reference Designation:  Onboard LAN
        Type: Ethernet
        Status: Enabled
        Type Instance: 1
        Bus Address: 0000:00:19.0

Handle 0x002B, DMI type 41, 11 bytes
Onboard Device
        Reference Designation:  Onboard 1394
        Type: Other
        Status: Enabled
        Type Instance: 1
        Bus Address: 0000:03:1c.2

@electrified electrified mentioned this pull request Apr 3, 2022
Closed
0lvin added a commit to free-z4u/roc-rk3328-cc that referenced this pull request Apr 3, 2022
@0lvin
hwmon: (asus_wmi_sensors) Fix CROSSHAIR VI HERO name
bb88ea7 
CROSSHAIR VI HERO motherboard is incorrectly named as
ROG CROSSHAIR VI HERO. Issue is found by github user in [1].

[1]: electrified/asus-wmi-sensors#79

Signed-off-by: Denis Pauk <[email protected]>
@electrified
Copy link
Owner Author

Crosshair VI Hero motherboard (non WiFi) sensor does not work with the version mainlined in kernel 5.17. The master version used in the AUR works with Crosshair VI Hero motherboard. The current master version refers to motherboard as "CROSSHAIR VI HERO" whereas the 5.17 mainlined version uses "ROG CROSSHAIR VI HERO".

Hey @spiffeeroo, Denis has submitted a patch upstream to correct the issue: https://lkml.org/lkml/2022/4/3/295

Thanks for reporting.

intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this pull request Apr 3, 2022
@0lvin @intel-lab-lkp
hwmon: (asus_wmi_sensors) Fix CROSSHAIR VI HERO name
bc60a10 
CROSSHAIR VI HERO motherboard is incorrectly named as
ROG CROSSHAIR VI HERO. Issue is found by github user in [1].

[1]: electrified/asus-wmi-sensors#79

Signed-off-by: Denis Pauk <[email protected]>
@0lvin
Copy link

0lvin commented Apr 4, 2022

Code is applied to hwmon tree. https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git/log/?h=hwmon

0lvin added a commit to free-z4u/roc-rk3328-cc that referenced this pull request May 3, 2022
@0lvin
hwmon: (asus_wmi_sensors) Fix CROSSHAIR VI HERO name
f4905b8 
CROSSHAIR VI HERO motherboard is incorrectly named as
ROG CROSSHAIR VI HERO. Issue is found by github user in [1].

[1]: electrified/asus-wmi-sensors#79

Signed-off-by: Denis Pauk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@electrified @spiffeeroo @0lvin