[Spike] High contrast mode #8036
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
force-pushed
the
high-contrast-mode
branch
3 times, most recently
from
51185df
to
9fd8832
Compare
cee-chen
force-pushed
the
high-contrast-mode
branch
3 times, most recently
from
e6e785b
to
dd894de
Compare
TODO: figure out how to compute this using getComputed/buildTheme instead
- and set a border-bottom instead via box-shadow + code style cleanup - use optional chaining syntax instead of destructuring and correctly pass all options
+ fix file picker to correctly inherit border color, which is `lightShade` in any case in non-high-contrast mode
+ tweak switches to account for changed border color
- contrast feels low otherwise - TODO: should we add this to all controls?
… high contrast mode + fix obvious components that require this - flyouts, modals, toasts, and mobile table rows
- apply borders instead of shadows so we can apply an extra bottom shadow on clickable panels/cards - TODO: get designer input, make sure this isn't too many borders
- requires some special finagling with popover arrows to get pseudo-borders (actually drop shadow filters) working - has about a pixel gap on closer inspection but this is good enough IMO - avoid `filter` on the parent panel in order to work with `hasDragDrop` behavior
…or high contrast borders
+ address focus background color TODO
- CSS cleanup: replace line-height with flex centering instead - this allows us to use borders of any thickness, and removes a lot of unnecessary vertical centering and tweaks (we can now remove all number styles completely) + clean up horizontal focus rings and make the focus outline better for current steps
+ massive cleanup/refactor of src-docs theme context, prefer toggle for light/dark mode + remove defunct tour on language selector
… ThemeContext - might as well since we're already handling localStorage things there, saves us from waterfalling props unnecessarily
cee-chen
force-pushed
the
high-contrast-mode
branch
from
dd894de
to
f284850
Compare
💚 Build Succeeded
History
cc @cee-chen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See #7509 (comment)
Screenshots
Extra reading/reference:
QA
General checklist
@defaultif default values are missing) and playground toggles