-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experiments with running ES with the entitlements agent enabled #115128
Draft
prdoyle
wants to merge
11
commits into
elastic:main
Choose a base branch
from
prdoyle:entitlements-testing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+131
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prdoyle
commented
Oct 18, 2024
@@ -69,3 +69,4 @@ testfixtures_shared/ | |||
# Generated | |||
checkstyle_ide.xml | |||
x-pack/plugin/esql/src/main/generated-src/generated/ | |||
x-pack/plugin/esql/gen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this guy again.
Ok I'm getting unit test failures because the jar file doens't exist at the expected path. I guess looking at the filesystem to find the jars wasn't so smart after all.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not looking to merge this; just making a PR for reviewability.
The headlines:
The bridge module now has an
spi
packageThe bridge module has become a useful "leaf module" that everything can depend on to interoperate:
api
package is what instrumented code calls to perform the checksspi
package is what the agent uses to load itsimpl
moduleorg.elasticsearch.base
, which needs access to any interfaces loaded by the embedded provider Gradle pluginThe bridge module itself has no dependencies.
ServerCLI changes
SystemJvmOptions.java
now has a stanza for the entitlement command line options. It usesFiles.newDirectoryStream
to locate the jar file within the working directory. (We could probably calculate this statically instead if that's preferable, but the obstacle is that the jar file name contains the version number, like-9.0.0
, which I wasn't sure how to access programmatically.)Hacks
LogManager.getLogger
inModuleQualifiedExportsService
Refactoring
You might want to review this commit separately. It's a simpler, more uniform way to knit together groups of zero or more options.