Better config resolving #37
Conversation
Signed-off-by: Charlike Mike Reagent <[email protected]>
lib/readMaidFile.js
Outdated
| */ | ||
| module.exports = (opts = {}) => { | ||
| let filepath = | ||
| find.sync(MAIDFILE, opts.cwd, 5) || find.sync(`.${MAIDFILE}`, opts.cwd, 10) |
There was a problem hiding this comment.
oh.. i forgot that, but it's not needed for find-file-up to work it uses the cwd by default anyway.
There was a problem hiding this comment.
use of the --cwd flag is not encouraged anyway, because it also may conflict with other CLIs (#35)
Signed-off-by: Charlike Mike Reagent <[email protected]>
Signed-off-by: Charlike Mike Reagent <[email protected]>
|
Btw, last commit may look strange, but is required and this problem probably comes from the you can see here how there is Definitely this should somehow be handled by Like for example running lint task should represent ? That's why #35 is reasonable and mostly sure it may appear as problem in future, and users should be caution when use |
|
TODO: update docs. |
|
@tunnckoCore, I have access to start merging, would you fix the conflicts and I will merge today. Thanks. |
| */ | ||
| module.exports = (opts = {}) => { | ||
| let filepath = | ||
| find.sync(MAIDFILE, null, 5) || find.sync(`.${MAIDFILE}`, null, 10) |
There was a problem hiding this comment.
What about simply using loadFile? It by default will stop searching files when reaching /.
loadFile.loadSync(['maidfile.md', '.maidfile.md'])
// not sure why we need to support .maidfile.md thoughAnd remove the stopDir here:
Line 7 in d2108b5
resolves #4 and deprecates #36 and #29 ;d
So what is the final result? There is a comment, but let's describe again.
If someone want one global config file they don't need to do anything or to use a
--maidfileflag - it just works. It will look 5-10 directories up to find such file, otherwise you should pass path to a markdown file (e.g.README.mdor~/myconfigs/maidconfig.md) which has h2 header and tasks names as h3 headers, the optional use of<!-- maid-tasks -->still work though.