Some OpenROAD Enhancements #608

donn · 2024-12-02T09:36:24Z

OpenROAD.*
- Added log_cmd from OpenROAD-flow-scripts -- neat idea for consistency
- Internal: Steps now sensitive to _OPENROAD_GUI environment variable -- coupled with --only, it runs a step in OpenROAD then doesn't quit so you may inspect the result.
  - This is not part of the OpenLane stable API and may be broken at any moment.
OpenROAD.CutRows
- Added FP_PRUNE_THRESHOLD to prune rows not meeting the threshold after cutting.
Created OpenROAD.UnplaceAll
- Removes the placement status of all instances.

Misc. Enhancements/Bugfixes

Changed some decimal.Decimal initializations to use integers or strings instead of floats.

* `Yosys.JsonHeader`, `Yosys.*Synthesis` * **Internal**: * Steps are no longer `TclStep`s: rewritten in Python and now use `libyosys`. While there are no functional changes, this enhances the codebase's consistency and helps avoid tokenization-related security issues. * `Yosys.*Synthesis` * ABC scripts used now created dynamically and dumped as a `.abc` file into the step directory. * Updated `nix-eda` * `yosys` -> `0.44` (+ `-y` patch) * `klayout` -> `0.29.4` * OpenROAD now used with new `withPythonPackages` features to use Python packages specifically for the OpenROAD environment

* `OpenROAD.*` * Added `log_cmd` from OpenROAD-flow-scripts -- neat idea for consistency * **Internal**: Steps now sensitive to `_OPENROAD_GUI` environment variable -- coupled with `--only`, it runs a step in OpenROAD then doesn't quit so you may inspect the result. * This is not part of the OpenLane stable API and may be broken at any moment. * `OpenROAD.CutRows` * Rows that generate less than a specified number of sites are now removed to help with PDN generation (default: 25) * Created `OpenROAD.HierarchicalMacroPlacer` * Based on OpenROAD `mpl2`-- a macro placer that uses hierarchy information from the RTL to generate a macro placement automatically * Used for macros for which a manual placement has not been provided * Created `OpenROAD.UnplaceAll` * Removes placement status of all instances. * `Yosys.Synthesis` * `SYNTH_NO_FLAT` replaced with `SYNTH_HIERARCHY_MODE` with three options: `flatten` (previously `false`), `deferred_flatten` (previously `true`) and `keep` (new value). When set to `keep`, the netlist generated is hierarchical. ## Flows * Classic * Added `OpenROAD.HierarchicalMacroPlacer` after `Odb.ManualMacroPlacement` * Moved pin placement flow before macro placement as `mpl2` requires pin placement information * Added `OpenROAD.UnplaceAll` after pin placement so rows can be cut for macros without worries about already-placed instances ## Tool Updates * `openroad` -> `49a497a` * Enhanced overlay for `or-tools` to fix a bug where trying to build OpenROAD from a git repo (using nix develop .#openroad) would Cmake always fail after the first `cmake ..`

commit e7a0e71 Author: Kareem Farid <[email protected]> Date: Sun Nov 3 13:22:53 2024 +0200 lint Signed-off-by: Kareem Farid <[email protected]> commit 9e25b72 Author: Kareem Farid <[email protected]> Date: Sun Nov 3 13:11:51 2024 +0200 update changelog, Verilator.Lint, Yosys.JsonHeader Signed-off-by: Kareem Farid <[email protected]> commit 36bca9b Author: Kareem Farid <[email protected]> Date: Sun Nov 3 12:52:59 2024 +0200 bugfix: allow unsetting variables in configuration files Signed-off-by: Kareem Farid <[email protected]> commit b0246e6 Author: Kareem Farid <[email protected]> Date: Tue Oct 29 15:29:20 2024 +0300 hotfix: incorrect error message when substiuting with a nonexistent step commit 19109e1 Author: Mohamed Gaber <[email protected]> Date: Sat Oct 26 20:12:12 2024 +0300 bugfix: odb steps dropping PYTHONPATH (#592) * `Odb.*` * Fixed OpenROAD dropping user-set `PYTHONPATH` values. ## Tool Updates * Use `NIX_PYTHONPATH` instead of `PYTHONPATH` in Docker and devshells to avoid collisions with user-set `PYTHONPATH` variables. commit 627a5ab Author: Mohamed Gaber <[email protected]> Date: Thu Oct 24 11:03:55 2024 +0300 nix: make flake.createOpenLane shell more ergonomic ## Tool Updates * `flake.createOpenLaneShell` now gets OpenLane from `python3.pkgs`. * Fixed issue with `flake.createOpenLaneShell` where plugins would not get included due to an operator precedence issue. commit 8451508 Author: Mohamed Gaber <[email protected]> Date: Thu Oct 24 10:57:58 2024 +0300 hotfix: regression in nix/create-shell.nix commit 1bfa43d Author: Mohamed Gaber <[email protected]> Date: Mon Oct 21 21:05:05 2024 +0300 Temporarily revert Colab's OpenLane version until it's fixed Signed-off-by: Kareem Farid <[email protected]>

openlane-bot · 2024-12-02T10:43:36Z

Metric comparisons are in beta. Please report bugs under the issues tab.

To create this report yourself, grab the metrics artifact from the CI run, extract them, and invoke python3 -m openlane.common.metrics compare-remote current --branch dev --table-verbosity ALL --table-out ./tables_all.md.

‼️ Results for sky130A/sky130_fd_sc_hd/blink appear to be missing!
Changes to critical metrics were detected in the following designs:
- sky130A/sky130_fd_sc_hd/MS_SPI_XIP_CACHE

Full tables ► https://gist.github.com/openlane-bot/f13f11e508408b96e303a797161ad6e7

openlane/scripts/openroad/cut_rows.tcl

openlane/scripts/openroad/gpl.tcl

openlane/steps/openroad.py

kareefardi · 2024-12-02T13:27:11Z

openlane/steps/openroad.py

            default=10,
            units="µm",
            deprecated_names=["FP_TAP_HORIZONTAL_HALO"],
        ),
        Variable(
            "FP_MACRO_VERTICAL_HALO",
            Decimal,
-            "Specify the vertical halo size around macros while cutting rows.",
+            "Specify the horizontal halo size around macros.",


kareefardi · 2024-12-02T13:32:55Z

openlane/scripts/openroad/gpl.tcl

@@ -53,8 +53,7 @@ if { $::env(PL_SKIP_INITIAL_PLACEMENT) } {
 	lappend arg_list -skip_initial_place
 }

-
-if { [info exists ::env(__PL_SKIP_IO)] } {
+if { $::env(STEP_ID) == "OpenROAD.GlobalPlacementSkipIO" } {


i recall avoiding this for some reason.

donn and others added 18 commits August 21, 2024 19:01

Exclude Pyosys Scripts from mypy

f752ac9

Fix missing passes in proc/synth

a5cfc8c

Fix VHDL and Power Defines Issues + Add booth/fix -dff

8082f54

Fix Lint

13b7c3a

Fix &nf usage

5b72255

Fix nonsynth deletes

7b36a6e

Fix vh

72875b8

Merge remote-tracking branch 'origin/main' into dev

66524bd

Merge remote-tracking branch 'origin/dev' into synthesis-adjustments

3d55222

lint michigan

29b3424

Update OpenROAD again + docs

a6fa5e6

Merge branch 'dev' into rtl-macro-placer

b8ea607

Rever HierRTLMP changes

c07e571

merge in dev

2675f26

Make pruning rows use an actual variable (forgot to commit)

9d37ee8

Replace prune threshold variable

0cec677

kareefardi reviewed Dec 2, 2024

View reviewed changes

openlane/scripts/openroad/cut_rows.tcl Show resolved Hide resolved

kareefardi reviewed Dec 2, 2024

View reviewed changes

openlane/scripts/openroad/gpl.tcl Outdated Show resolved Hide resolved

kareefardi reviewed Dec 2, 2024

View reviewed changes

openlane/steps/openroad.py Outdated Show resolved Hide resolved

kareefardi reviewed Dec 2, 2024

View reviewed changes

Address review feedback

4d726a7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Some OpenROAD Enhancements #608

Some OpenROAD Enhancements #608

donn commented Dec 2, 2024 •

edited

Loading

openlane-bot commented Dec 2, 2024 •

edited

Loading

kareefardi Dec 2, 2024

kareefardi Dec 2, 2024

Some OpenROAD Enhancements #608

Are you sure you want to change the base?

Some OpenROAD Enhancements #608

Conversation

donn commented Dec 2, 2024 • edited Loading

Misc. Enhancements/Bugfixes

openlane-bot commented Dec 2, 2024 • edited Loading

Metric comparisons are in beta. Please report bugs under the issues tab.

kareefardi Dec 2, 2024

Choose a reason for hiding this comment

kareefardi Dec 2, 2024

Choose a reason for hiding this comment

donn commented Dec 2, 2024 •

edited

Loading

openlane-bot commented Dec 2, 2024 •

edited

Loading