Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Effects.cpp for consistent behavior when rendering special patterns #1216

Closed
wants to merge 4 commits into from
Closed

Conversation

LeandroLibanio28H
Copy link

The current rendering behavior of spell effects with patternX = 2 and patternY = 2 exhibits inconsistency, as demonstrated in the provided video:

wrong_spell_effect.mp4

As an example, I've modified the "Eternal Winter" spell area to the following:

local area = {
	{0, 0, 0, 1, 0, 0, 0},
	{0, 0, 1, 1, 1, 0, 0},
	{0, 1, 1, 1, 1, 1, 0},
	{1, 1, 1, 2, 1, 1, 1},
	{0, 1, 1, 1, 1, 1, 0},
	{0, 0, 1, 1, 1, 0, 0},
	{0, 0, 0, 1, 0, 0, 0},
}

The spell pattern rendering is incompatible with the designated combat area. This pull request aims to rectify the issue by adjusting the effect rendering pattern formula to consistently align with the desired combat area, regardless of the pattern the object possesses.

@LeandroLibanio28H LeandroLibanio28H changed the title Update Effects.cpp for consistent behavior when rendering special pat… Update Effects.cpp for consistent behavior when rendering special patterns Mar 30, 2024
@LeandroLibanio28H LeandroLibanio28H closed this by deleting the head repository Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant