Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix identity function derivatives and remove ancient/dead test code #1492

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mnwhite
Copy link
Contributor

@mnwhite mnwhite commented Sep 3, 2024

This PR fixes a typo in the derivative methods of interpolation.IdentityFunc that has gone undetected for years. It also (finally) deletes hundreds of lines of unused tests that I wrote it in 2015 and early 2016.

  • Update CHANGELOG.md with major/minor changes.

There has been an errant asterisk in the arguments of the (trivial) derivative method functions for IdentityFunction for an unknown amount of time. These methods did not work, and apparently were never tested.
For years, the bottom of interpolation.py has had a main() function with test code that I wrote in 2015 or 2016. This code is never used or run, and could not be, as it has many obvious errors in it. This commit deletes that old dead code.
@sbenthall
Copy link
Contributor

It would best if there was an automated test for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants