Move CI to an independent crate. #362
Open
+218
−194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ChenYing Kuo <[email protected]>
|
PR missing one of the required labels: {'breaking-change', 'dependencies', 'bug', 'documentation', 'internal', 'enhancement', 'new feature'} |
Signed-off-by: ChenYing Kuo <[email protected]>
Signed-off-by: ChenYing Kuo <[email protected]>
Signed-off-by: ChenYing Kuo <[email protected]>
evshary
commented
Dec 12, 2024
| @@ -46,7 +46,7 @@ jobs: | |||
| - name: Code format check | |||
| run: cargo fmt --check -- --config "unstable_features=true,imports_granularity=Crate,group_imports=StdExternalCrate" | |||
| - name: Clippy | |||
| run: cargo clippy --all --examples -- -D warnings | |||
| run: cargo clippy --workspace --all-targets --all-features -- --deny warnings | |||
There was a problem hiding this comment.
@JEnoch I updated the clippy argument here to match the one we used in Zenoh. I added --all-targets and --all-features to avoid the possible changes in the future. Also, --all is replaced by --workspace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
r2rCI to an independent crate to avoid blocking our release processShould resolve #359