Skip to content

Commit

Permalink
Specify a global timeout of 90 min. for the GitHub build jobs (#471)
Browse files Browse the repository at this point in the history
The Jenkins build currently sets two timeouts. A 90 min. timeout for the
entire build and a 60 min. timeout for the JUnit tests.

Whenever we want to adjust the timeout, we have to separate places to
edit (the pom.xml file on the test bundle and the Jenkinsfile). We
should drop the timeout of the tests and simply rely on the global
timeout.

Note that we GitHub workflow already has a timeout of 5h by default. It
is lowered to 90min to avoid excessive build times in case it ever gets
stuck and to keep in in sync with the Jenkins build.
  • Loading branch information
ptziegler authored Jun 7, 2023
1 parent 47f807f commit 4d7d79c
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/maven.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ jobs:
java: [ 17 ]
runs-on: ${{ matrix.os }}
name: OS ${{ matrix.os }} Java ${{ matrix.java }} compile
timeout-minutes: 90
steps:
- uses: actions/checkout@v3
with:
Expand Down
1 change: 0 additions & 1 deletion org.eclipse.wb.tests/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@
<configuration>
<argLine>${ui.test.vmargs}</argLine>
<appArgLine>-nl de -clearPersistedState -consoleLog</appArgLine>
<forkedProcessTimeoutInSeconds>3600</forkedProcessTimeoutInSeconds>
<useUIHarness>true</useUIHarness>
<useUIThread>true</useUIThread>
<application>org.eclipse.ui.ide.workbench</application>
Expand Down

0 comments on commit 4d7d79c

Please sign in to comment.