Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bdrs): add custom bpndidresolver token address #474

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tfjanjua
Copy link
Contributor

@tfjanjua tfjanjua commented Nov 5, 2024

Description

Add environment variables for bdrs token configuration.

Why

Client id and secret are more secure than API keys.

Issue

Ref: #456

Corresponding Backend PR

eclipse-tractusx/portal-backend#1129

Checklist

Please delete options that are not relevant.

  • I have performed a self-review of my changes
  • I have successfully tested my changes
  • I have added comments in the default values.yaml file with helm-docs syntax ('# -- ') if relevant for installation
  • I have commented my changes, particularly in hard-to-understand areas

Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes so that the PR doesn't get merged until there's an according change on BDRS side eclipse-tractusx/sig-release#959 (comment)

charts/localdev/values.yaml Outdated Show resolved Hide resolved
charts/portal/templates/cronjob-backend-processes.yaml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: IN REVIEW
Development

Successfully merging this pull request may close these issues.

2 participants