chore(BPDM): Set BPDM pool url #472
Conversation
tfjanjua
requested review from
evegufy and
Phil91
and removed request for
evegufy
| @@ -147,6 +147,8 @@ spec: | |||
| value: "{{ .Values.backend.useDimWallet }}" | |||
| - name: "APPLICATIONCHECKLIST__BPDM__STARTSHARINGSTATEASREADY" | |||
| value: "{{ .Values.backend.processesworker.bpdm.startSharingStateAsReady }}" | |||
| - name: "APPLICATIONCHECKLIST__BPDM__BUSINESSPARTNERPOOLBASEADDRESS" | |||
| value: "{{ .Values.bpdm.poolAddress }}{{ .Values.bpdm.poolApiPath }}" | |||
There was a problem hiding this comment.
this is referring to a path:
but expected is a full url:
https://github.com/eclipse-tractusx/portal-backend/blob/c649d4d243c4d84d1b840d5b1d101ac77750993d/src/externalsystems/Bpdm.Library/BpdmService.cs#L188
There was a problem hiding this comment.
Config param APPLICATIONCHECKLIST__BPDM__BUSINESSPARTNERPOOLBASEADDRESS has the following value:
https://business-partners-pool.example.com/pool/v6
and rest of the url part (v6/cx-memberships) has already been placed while calling it from httpClient:
https://github.com/eclipse-tractusx/portal-backend/blob/c649d4d243c4d84d1b840d5b1d101ac77750993d/src/externalsystems/Bpdm.Library/BpdmService.cs#L195C42-L195C59
So, its like:
https://business-partners-pool.example.com/pool/v6/v6/cx-memberships
So, I think no full url is expected.
However, since url part (v6/cx-memberships) has already been placed so, I can remove the poolApiPath from the value of config param APPLICATIONCHECKLIST__BPDM__BUSINESSPARTNERPOOLBASEADDRESS
So, then config param APPLICATIONCHECKLIST__BPDM__BUSINESSPARTNERPOOLBASEADDRESS will be:
https://business-partners-pool.example.com/
and rest of the url part (v6/cx-memberships) will make it:
https://business-partners-pool.example.com/v6/cx-memberships
| @@ -117,6 +117,8 @@ spec: | |||
| value: "{{ .Values.backend.useDimWallet }}" | |||
| - name: "APPLICATIONCHECKLIST__BPDM__STARTSHARINGSTATEASREADY" | |||
| value: "{{ .Values.backend.processesworker.bpdm.startSharingStateAsReady }}" | |||
| - name: "APPLICATIONCHECKLIST__BPDM__BUSINESSPARTNERPOOLBASEADDRESS" | |||
| value: "{{ .Values.bpdm.poolAddress }}{{ .Values.bpdm.poolApiPath }}" | |||
There was a problem hiding this comment.
this is referring to a path:
but expected is a full url:
https://github.com/eclipse-tractusx/portal-backend/blob/c649d4d243c4d84d1b840d5b1d101ac77750993d/src/externalsystems/Bpdm.Library/BpdmService.cs#L188
There was a problem hiding this comment.
Config param APPLICATIONCHECKLIST__BPDM__BUSINESSPARTNERPOOLBASEADDRESS has the following value:
https://business-partners-pool.example.com/pool/v6
and rest of the url part (v6/cx-memberships) has already been placed while calling it from httpClient:
https://github.com/eclipse-tractusx/portal-backend/blob/c649d4d243c4d84d1b840d5b1d101ac77750993d/src/externalsystems/Bpdm.Library/BpdmService.cs#L195C42-L195C59
So, its like:
https://business-partners-pool.example.com/pool/v6/v6/cx-memberships
So, I think no full url is expected.
However, since url part (v6/cx-memberships) has already been placed so, I can remove the poolApiPath from the value of config param APPLICATIONCHECKLIST__BPDM__BUSINESSPARTNERPOOLBASEADDRESS
So, then config param APPLICATIONCHECKLIST__BPDM__BUSINESSPARTNERPOOLBASEADDRESS will be:
https://business-partners-pool.example.com/
and rest of the url part (v6/cx-memberships) will make it:
https://business-partners-pool.example.com/v6/cx-memberships
Description
Set BPDM pool url to call Business Partner Pool
Why
Required for: Set Catena-X Membership in BPDM.
Issue
Ref: #471
eclipse-tractusx/portal-backend#1118
Checklist