-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config option to skip idlcxx building if crosscompiling #189
base: master
Are you sure you want to change the base?
Conversation
Skip idlcxx module building if crosscompiling. A native one should be used in that case. Signed-off-by: Matija Tudan <[email protected]>
This is somewhat similar to #183, but it also has some support in the |
Like @k0ekk0ek mentioned in #183, the idea was to implement the same thing like in But, after discussing with @eboasson in #191, we will implement more generic function in |
Combining them may not be the best way forward. I previously thought about the same thing but C++ is really different from C. I'm happy to review or provide input of course, but back then I thought it would introduce more problems then it solves. An example: C++ currently only generates a header, not a source file and a header like C. I know that'll change when X-Types lands, but still. Other than that, without having properly reviewed it yet, this seems like what I had in mind. |
This is not true anymore (after #178 is merged). I'm hoping it's on the final straight :) |
To be fair, about the C++ generation (and about idlc supporting multiple languages), it makes sense most options to be "bookkeeping" and apply to all languages, and if there are language-specific options it makes a lot of sense for them to be prefixed with the language (like Update: If at a later point some language-specific options are found to be present across multiple languages, then a 2nd variant |
Hi @ichernev, that's actually sort-of how it's implemented already. Options that apply to the parser or all backends are kept by the compiler, each backend can then add options (and annotations) that apply only to that backend. e.g. the C++ backend supports the use of custom containers for unions etc. |
Excuse me, how did you compile the cross-compilation? I didn't find any relevant information. |
Skip idlcxx module building if crosscompiling. A native one should
be used in that case.
Signed-off-by: Matija Tudan [email protected]