Add IgnoreLocal reader, writer QoS setting #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eboasson the branch has conflicts, may you can merge the current master into the branch? |
Signed-off-by: Erik Boasson <[email protected]>
eboasson
force-pushed
the
ignorelocal-qos
branch
from
2248f62
to
4be91b0
Compare
|
@trittsv done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Cyclone's "ignore local" QoS setting to the C++ API. Fixes #139.
Something strikes me as odd, and that's that adding a very simple QoS policy to what is no more than a C++ wrapper around the C API touches 10 files/+275/-12 lines. The original introduction of the policy in Cyclone (that is, API and implementation) touched 5 files/+103 lines (eclipse-cyclonedds/cyclonedds@4778d6c).
Maybe I did something wrong, I don't know. @e-hndrks, perhaps you can have a look?