Build OPC-UA Support in Github Workflow #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azoitl
requested changes
Apr 2, 2024
| @@ -65,6 +65,14 @@ jobs: | |||
| if: ${{ matrix.os == 'windows-latest' }} | |||
| run: nuget install boost -Version 1.84.0 | |||
|
|
|||
| - name: Install OPC-UA | |||
| run: | | |||
| git clone https://github.com/open62541/open62541 -b v1.3.4 | |||
There was a problem hiding this comment.
this should definitely be a newer version, see for example the recent update in 4diac Build Environment: eclipse-4diac/4diac-fbe@4246377
There was a problem hiding this comment.
I think it would make sense to extract the build procedures of other libraries into separate yml files/functions as the workflow gets cluttered already with all the libraries.
But I must admiti didn't take a look on how to do that
| @@ -90,7 +102,7 @@ jobs: | |||
| -DFORTE_MODULE_SIGNALPROCESSING=ON | |||
| -DFORTE_MODULE_UTILS=ON | |||
| -DFORTE_TESTS=ON | |||
| ${{ matrix.os == 'windows-latest' && format('-DFORTE_TESTS_INC_DIRS={0}/boost.1.84.0/lib/native/include', github.workspace) || '' }} | |||
There was a problem hiding this comment.
I would put this into he matrix settings to remove the if here
There was a problem hiding this comment.
Not sure if this is possible in this situation though
mhansal
force-pushed
the
feature/build-opc-ua
branch
from
eb2d246
to
48554f1
Compare
mhansal
force-pushed
the
feature/build-opc-ua
branch
from
48554f1
to
c54e566
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.