Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved messages + tests into each special page #1299

Merged
merged 8 commits into from
Dec 3, 2024

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Dec 3, 2024

Asana Task/Github Issue: https://app.asana.com/0/1201141132935289/1208895750935171/f

Description

  • moved special-pages message definitions into each page's directory
  • moved integration tests into each page's directory too

Testing Steps

  • If the existing test suite passing, we're all good.

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit b8ad941
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/674f42b4d54cf70008ddd336
😎 Deploy Preview https://deploy-preview-1299--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shakyShane
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Dec 3, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Dec 3, 2024

[Beta] Generated file diff

Time updated: Tue, 03 Dec 2024 17:42:05 GMT

Android
    - android/pages/duckplayer/js/index.js

File has changed

Integration
    - integration/pages/duckplayer/js/index.js
  • integration/pages/example/js/index.js
  • integration/pages/new-tab/js/index.js
  • integration/pages/onboarding/js/mock-transport.js
  • integration/pages/release-notes/js/index.js
  • integration/pages/release-notes/js/mock-transport.js
  • integration/pages/special-error/js/index.js
  • integration/pages/special-error/js/sampleData.js

File has changed

Windows
    - windows/pages/duckplayer/js/index.js
  • windows/pages/new-tab/js/index.js
  • windows/pages/onboarding/js/mock-transport.js

File has changed

Apple
    - dist/pages/duckplayer/index.html
  • dist/pages/duckplayer/js/index.js
  • dist/pages/new-tab/js/index.js
  • dist/pages/onboarding/js/mock-transport.js
  • dist/pages/release-notes/js/index.js
  • dist/pages/release-notes/js/mock-transport.js
  • dist/pages/special-error/index.html
  • dist/pages/special-error/js/index.js
  • dist/pages/special-error/js/sampleData.js

File has changed

@shakyShane shakyShane marked this pull request as ready for review December 3, 2024 16:00
@shakyShane shakyShane requested a review from a team as a code owner December 3, 2024 16:00
@shakyShane shakyShane changed the title moved messages Moved messages + tests into each special page Dec 3, 2024
special-pages/types.mjs Outdated Show resolved Hide resolved
Copy link
Contributor

@mgurgel mgurgel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks

@shakyShane shakyShane merged commit 0548bdf into main Dec 3, 2024
13 checks passed
@shakyShane shakyShane deleted the shane/colocate-messages branch December 3, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants