Intercept requests and add skeleton for malicious site detection #5369
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| } | ||
|
|
||
| @Test | ||
| fun `shouldOverride returns true when feature is enabled, is malicious, and not mainframe nor iframe`() = runTest { |
There was a problem hiding this comment.
The test name appears to be incorrect - it states "returns true" but the test asserts false. Consider renaming to shouldOverride returns false when feature is enabled, is malicious, and not mainframe nor iframe to accurately reflect the expected behavior being tested.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
CrisBarreiro
force-pushed
the
feature/cris/malicious-site-protection/intercept-requests
branch
2 times, most recently
from
13cfb3a to
8d0f3b0
Compare
CrisBarreiro
force-pushed
the
feature/cris/malicious-site-protection/intercept-requests
branch
from
8d0f3b0 to
0b7f33d
Compare
| return WebResourceResponse(null, null, null) | ||
| } | ||
| processedUrls.add(decodedUrl) | ||
| } else if (isForIframe(request) && documentUri?.host == request.requestHeaders["Referer"]?.toUri()?.host) { |
There was a problem hiding this comment.
The toUri() call on the Referer header value needs null-safety and exception handling. A malformed URI in the header could crash the app. Consider wrapping this in a try-catch block and providing a fallback value when the URI is invalid or malformed.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Task/Issue URL: https://app.asana.com/0/1205008441501016/1207151848931035/f
Description
Steps to test this PR
Feature 1
Timber.tag("MaliciousSiteProtection").d("isMalicious $url")for all mainframe and iframe requests (only for internal builds).UI changes