Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Settings design: Add new SettingsListItem #5318

Merged
merged 8 commits into from
Dec 2, 2024
Merged

Update Settings design: Add new SettingsListItem #5318

merged 8 commits into from
Dec 2, 2024

Commits on Dec 2, 2024

  1. duplicating content settings and privacy

    @mikescamell
    mikescamell committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    c6be3dd View commit details
    Browse the repository at this point in the history

  2. add new icons

    @mikescamell
    mikescamell committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    5d543b0 View commit details
    Browse the repository at this point in the history

  3. add new SettingsListItem

    @mikescamell
    mikescamell committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    a0b9993 View commit details
    Browse the repository at this point in the history

  4. switch to SettingsListItem in privacy section 

    Also adding all the new icons, removing secondary text and itemState, and adding the new isOn for search and web tracking settings

Next commit we'll ensure the indicators are on/off
    @mikescamell
    mikescamell committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    2962eb3 View commit details
    Browse the repository at this point in the history

  5. set items to on/off based on state 

    I've removed appTrackingProtectionOnboardingShown state as only have 2 states now, on/off, but I will follow up and ask Thomas if this is expected
    @mikescamell
    mikescamell committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    7c23cf1 View commit details
    Browse the repository at this point in the history

  6. add SettingsListItem to ADS 

    I think this is worth having on the ADS screen, even if not officially a component. Happy to move it if needs be.
    @mikescamell
    mikescamell committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    058fccc View commit details
    Browse the repository at this point in the history

  7. formatting

    @mikescamell
    mikescamell committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    6aa74a2 View commit details
    Browse the repository at this point in the history

  8. Fix status indicator alignment

    @mikescamell
    mikescamell committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    26b24c0 View commit details
    Browse the repository at this point in the history