Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporary pixel for visit site suggestions CTA display count #5309

Merged
merged 5 commits into from
Nov 29, 2024
Merged

Temporary pixel for visit site suggestions CTA display count #5309

merged 5 commits into from
Nov 29, 2024

Conversation

nalcalag
Copy link
Contributor

@nalcalag nalcalag commented Nov 22, 2024 •
edited by cmonfortep
Loading

Task/Issue URL: https://app.asana.com/0/488551667048375/1208778105886340/f

Description

Add temporary pixel for counting display of visit site suggestions dialog

Steps to test this PR

Feature 1

  • Fresh install
  • Once in the browser, tap on a search suggestion
  • Dismiss SERP dialog
  • Logcat: Check onboarding_visit_site_cta_shown pixel is fired with parameter count = 0
  • Open a new tab
  • Logcat: Check onboarding_visit_site_cta_shown pixel is fired with parameter count = 1
  • Close and open the app
  • Logcat: Check onboarding_visit_site_cta_shown pixel is fired with parameter count = 2
  • Perform a search
  • Open a new tab
  • Logcat: Check onboarding_visit_site_cta_shown pixel is fired with parameter count = 3
  • Tap on a site suggestion or navigate to a site
  • Check Trackers dialog appears
  • Open a new tab
  • Check End dialog is shown and onboarding_visit_site_cta_shown pixel is not fired

No UI changes

@nalcalag
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nalcalag nalcalag force-pushed the feature/noelia/temporary_pixel_for_visit_site_cta_shown_count branch from 4d1cebc to 8c9de35 Compare November 22, 2024 16:25
@nalcalag nalcalag marked this pull request as ready for review November 22, 2024 16:25
@nalcalag nalcalag force-pushed the feature/noelia/temporary_pixel_for_visit_site_cta_shown_count branch from 8c9de35 to 67f34d3 Compare November 22, 2024 16:51
@nalcalag nalcalag force-pushed the feature/noelia/temporary_pixel_for_visit_site_cta_shown_count branch from 1b08248 to d0936d4 Compare November 25, 2024 18:13
cmonfortep
cmonfortep approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@cmonfortep cmonfortep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

app/src/main/java/com/duckduckgo/app/cta/ui/CtaViewModel.kt Show resolved Hide resolved
app/src/main/java/com/duckduckgo/app/cta/ui/CtaViewModel.kt Outdated Show resolved Hide resolved
app/src/main/java/com/duckduckgo/app/onboarding/store/OnboardingStore.kt Outdated Show resolved Hide resolved
@nalcalag nalcalag force-pushed the feature/noelia/temporary_pixel_for_visit_site_cta_shown_count branch from d0936d4 to 8428603 Compare November 29, 2024 11:33
@nalcalag nalcalag merged commit 808b6a0 into develop Nov 29, 2024
6 checks passed
@nalcalag nalcalag deleted the feature/noelia/temporary_pixel_for_visit_site_cta_shown_count branch November 29, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonfortep cmonfortep cmonfortep approved these changes

Assignees

@cmonfortep cmonfortep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nalcalag @cmonfortep