Skip to content

Commit

Permalink
Prevent build crash on linter warnings. Revert tracking #457
Browse files Browse the repository at this point in the history
  • Loading branch information
fguitton committed Apr 6, 2020
1 parent cf7e3db commit ff80c61
Showing 1 changed file with 14 additions and 14 deletions.
28 changes: 14 additions & 14 deletions packages/scripts/scripts/build.js
Original file line number Diff line number Diff line change
Expand Up @@ -195,20 +195,20 @@ function build(previousFileSizes) {
}
return reject(new Error(messages.errors.join('\n\n')));
}
if (
process.env.CI &&
(typeof process.env.CI !== 'string' ||
process.env.CI.toLowerCase() !== 'false') &&
messages.warnings.length
) {
console.log(
chalk.yellow(
'\nTreating warnings as errors because process.env.CI = true.\n' +
'Most CI servers set it automatically.\n'
)
);
return reject(new Error(messages.warnings.join('\n\n')));
}
// if (
// process.env.CI &&
// (typeof process.env.CI !== 'string' ||
// process.env.CI.toLowerCase() !== 'false') &&
// messages.warnings.length
// ) {
// console.log(
// chalk.yellow(
// '\nTreating warnings as errors because process.env.CI = true.\n' +
// 'Most CI servers set it automatically.\n'
// )
// );
// return reject(new Error(messages.warnings.join('\n\n')));
// }

return resolve({
stats,
Expand Down

0 comments on commit ff80c61

Please sign in to comment.