attempt to fix issue 198

[esterguri]

We added a check to see if the default value is being used or if the user is setting the value.

[netlify]

✅ Deploy Preview for silly-keller-664934 ready!

Name	Link
🔨 Latest commit	34f8cf7
🔍 Latest deploy log	https://app.netlify.com/sites/silly-keller-664934/deploys/643cdc988e3fd5000871e26f
😎 Deploy Preview	https://deploy-preview-269--silly-keller-664934.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[ejm714]

This PR is misunderstanding the intent of issue #198. The goal in that issue is to avoid the warning about providing split proportions if this is just the default value that is there. This PR still logs that error and just changes the default value.

The fix may entail adding a clause in the top line of this block that checks if the values are not the default ones before surfacing this error

zamba/zamba/models/config.py

Lines 524 to 529 in 1ebcd41

	elif values["split_proportions"] is not None:
	logger.warning(
	"Labels contains split column yet split_proportions are also provided. Split column in labels takes precedence."
	)
	# set to None for clarity in final configuration.yaml
	values["split_proportions"] = None