Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

394 makefile fixes #395

Merged
merged 2 commits into from
Jul 12, 2024
Merged

394 makefile fixes #395

merged 2 commits into from
Jul 12, 2024

Conversation

pjbull
Copy link
Member

@pjbull pjbull commented Jul 12, 2024

A few tweaks to Makefile commands

  • Added whitespace to sync_data_down
  • Swapped order for sync_data_up
  • Fix conditional profile logic in sync_data_up (so it matches sync_data_down)
  • Fix path for make data

Closes #394

Tested manually:

❯ ccds .
project_name (project_name):
repo_name (project_name):
module_name (project_name):
author_name (Your name (or your organization/company/team)):
description (A short description of the project.):
python_version_number (3.10):
Select dataset_storage
    1 - none
    2 - azure
    3 - s3
    4 - gcs
    Choose from [1/2/3/4] (1): 3
bucket (bucket-name): drivendata-ccds-test
aws_profile (default):
Select environment_manager
    1 - virtualenv
    2 - conda
    3 - pipenv
    4 - none
    Choose from [1/2/3/4] (1):
Select dependency_file
    1 - requirements.txt
    2 - environment.yml
    3 - Pipfile
    Choose from [1/2/3] (1):
Select pydata_packages
    1 - none
    2 - basic
    Choose from [1/2] (1):
Select open_source_license
    1 - No license file
    2 - MIT
    3 - BSD-3-Clause
    Choose from [1/2/3] (1):
Select docs
    1 - mkdocs
    2 - none
    Choose from [1/2] (1):
Select include_code_scaffold
    1 - Yes
    2 - No
    Choose from [1/2] (1):

❯ cd project_name/
❯ make sync_data_up
aws s3 sync data/ \
		s3://drivendata-ccds-test/data
upload: data/external/.gitkeep to s3://drivendata-ccds-test/data/external/.gitkeep
upload: data/processed/.gitkeep to s3://drivendata-ccds-test/data/processed/.gitkeep
upload: data/interim/.gitkeep to s3://drivendata-ccds-test/data/interim/.gitkeep
upload: data/raw/.gitkeep to s3://drivendata-ccds-test/data/raw/.gitkeep
cookiecutter-data-science/project_name on  394-makefile-fixes [$?] is 📦 v0.0.1 via 🐍 v3.12.4 on ☁️  [email protected] took 6s

❯ make sync_data_down
aws s3 sync s3://drivendata-ccds-test/data/ \
		data/

❯ make data
python project_name/dataset.py
2024-07-11 17:33:04.156 | INFO     | project_name.config:<module>:11 - PROJ_ROOT path is: /Users/bull/code/cookiecutter-data-science/project_name
2024-07-11 17:33:04.160 | INFO     | __main__:main:20 - Processing dataset...
2024-07-11 17:33:04.416 | INFO     | __main__:main:23 - Something happened for iteration 5.
100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████| 10/10 [00:00<00:00, 15240.93it/s]
2024-07-11 17:33:04.417 | SUCCESS  | __main__:main:24 - Processing dataset complete.

@pjbull pjbull requested review from jayqi and chrisjkuch July 12, 2024 00:34
@pjbull pjbull merged commit cd47b9c into master Jul 12, 2024
16 checks passed
@pjbull pjbull deleted the 394-makefile-fixes branch July 12, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong path for the "make data" command in Makefile
2 participants