Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(conditional-formatting): init #4164

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

refactor(conditional-formatting): init #4164

wants to merge 2 commits into from

Conversation

Gggpound
Copy link
Contributor

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 27, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 27, 2024

Playwright test results

passed  20 passed

Details

stats  20 tests across 9 suites
duration  4 minutes, 48 seconds
commit  e49af70
info  For more information, see full report

@zhaolixin7
Copy link

zhaolixin7 commented Nov 27, 2024

@Gggpound 1、数据条百分比、公式等设置最大最小值时数据条渲染错误,预期:不符合的单元格不显示数据条
截屏2024-11-27 17 54 24
image
2、数据条中数据有0时,预期:不显示数据条
image
3、色阶最大最小值为公式时渲染结果不对(截图右侧是线上的表现)
截屏2024-11-27 19 06 51
4、条件格式自定义公式,符合条件单元格未高亮
预期:截图单元格C1高亮显示(线上有高亮,截图中相同配置数据验证符合条件未报错)
2024_11_27 20_11_25 snapshot.json
image

@univer-bot
Copy link

univer-bot bot commented Nov 27, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@Gggpound 1. The data bar rendering error occurs when the maximum and minimum values ​​of data bar percentages, formulas, etc. are set. Expected: Data bars are not displayed for cells that do not meet the requirements.
Screenshot 2024-11-27 17 54 24
image
2. When the data in the data bar contains 0, it is expected that the data bar will not be displayed.
image
3. When the maximum and minimum values ​​of the color scale are formulas, the rendering result is incorrect (the right side of the screenshot is the online performance)
Screenshot 2024-11-27 19 06 51
4. Conditional formatting custom formula, cells that meet the conditions are not highlighted
Expected: Cell C1 in the screenshot is highlighted (there is a highlight on the line, and the same configuration data in the screenshot is verified to meet the conditions and no error is reported)
2024_11_27 20_11_25 snapshot.json
image

@Gggpound Gggpound force-pushed the feat-cf-1125 branch 2 times, most recently from 46ecf4f to d28c36d Compare November 27, 2024 13:35
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 52.10970% with 227 lines in your changes missing coverage. Please review.

Project coverage is 33.79%. Comparing base (1a9f83d) to head (e49af70).

Files with missing lines Patch % Lines
...odels/calculate-unit-v2/icon-set-calculate-unit.ts 1.63% 60 Missing ⚠️
...odels/calculate-unit-v2/data-bar-calculate-unit.ts 61.90% 32 Missing ⚠️
...src/models/conditional-formatting-view-model-v2.ts 73.83% 28 Missing ⚠️
...services/conditional-formatting-formula.service.ts 6.66% 28 Missing ⚠️
...calculate-unit-v2/highlight-cell-calculate-unit.ts 47.61% 22 Missing ⚠️
...matting-ui/src/controllers/cf.render.controller.ts 0.00% 11 Missing ⚠️
...ing/src/services/conditional-formatting.service.ts 47.61% 11 Missing ⚠️
...rc/models/calculate-unit-v2/base-calculate-unit.ts 82.45% 10 Missing ⚠️
...ing-ui/src/controllers/cf.copy-paste.controller.ts 0.00% 6 Missing ⚠️
...ting-ui/src/controllers/cf.auto-fill.controller.ts 0.00% 5 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4164      +/-   ##
==========================================
+ Coverage   33.77%   33.79%   +0.01%     
==========================================
  Files        2457     2457              
  Lines      127720   127562     -158     
  Branches    28604    28586      -18     
==========================================
- Hits        43139    43104      -35     
+ Misses      84581    84458     -123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants