Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support format-painter in row & col selection #3616

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

yuhongz
Copy link
Contributor

@yuhongz yuhongz commented Sep 28, 2024

close https://github.com/dream-num/univer-pro/issues/2518
close https://github.com/dream-num/univer-pro/issues/2568
close https://github.com/dream-num/univer-pro/issues/2712

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Sep 28, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Sep 28, 2024

Playwright test results

passed  8 passed

Details

stats  8 tests across 3 suites
duration  2 minutes, 10 seconds
commit  4a47bbd
info  For more information, see full report

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

Attention: Patch coverage is 46.29630% with 58 lines in your changes missing coverage. Please review.

Project coverage is 31.81%. Comparing base (1113984) to head (4a47bbd).
Report is 14 commits behind head on dev.

Files with missing lines Patch % Lines
...ollers/format-painter/format-painter.controller.ts 45.79% 58 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3616      +/-   ##
==========================================
- Coverage   31.87%   31.81%   -0.06%     
==========================================
  Files        2193     2194       +1     
  Lines      115294   115592     +298     
  Branches    25402    25451      +49     
==========================================
+ Hits        36745    36771      +26     
- Misses      78549    78821     +272     
Flag Coverage Δ
31.81% <46.29%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo oumomomo added the qa:untested This PR is ready to be tested label Sep 29, 2024
@oumomomo
Copy link

https://github.com/dream-num/univer-pro/issues/2712
全部合并单元格的区域大于垂直单元格的区域,垂直使用格式刷时单元格大小未保持一致, 边框线也不完整
2024_9_29 11_57_48 video.webm
image

google:垂直合并单元格变成全部合并单元格时范围大小保持一致
2024_9_29 11_59_20 video.webm
image

@univer-bot
Copy link

univer-bot bot commented Sep 29, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

https://github.com/dream-num/univer-pro/issues/2712
The area of ​​all merged cells is larger than the area of ​​vertical cells. When using the format painter vertically, the cell sizes are not consistent and the border lines are incomplete.
2024_9_29 11_57_48 video.webm
image

Google: When vertically merging cells into all merged cells, the range size remains the same
2024_9_29 11_59_20 video.webm
image

@oumomomo
Copy link

https://github.com/dream-num/univer-pro/issues/2712
前提条件:全部合并单元格<垂直合并单元格
选中合并单元格对垂直单元格使用格式刷,待研发确定预期
2024_9_29 14_25_37 video.webm
image

google表现:
2024_9_29 14_27_17 video.webm
image

@univer-bot
Copy link

univer-bot bot commented Sep 29, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

https://github.com/dream-num/univer-pro/issues/2712
Prerequisite: All merged cells < vertically merged cells
Select the merged cells and use the format painter for vertical cells, pending R&D to determine expectations
2024_9_29 14_25_37 video.webm
image

Google performance:
2024_9_29 14_27_17 video.webm
image

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants