Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidekiq does not start with environment variables #6

Closed
wants to merge 6 commits into from

Conversation

johncblandii
Copy link

Two different apps need env vars but they aren't passed with the start command. There may be a better way but this one is tested in two stacks and it works.

Code originally done by @codeodor.

@codeodor
Copy link

👍 Thanks for the shoutout and for offering the change back to the public!

@johncblandii
Copy link
Author

Absolutely hombre! ;)

@fbbergamo
Copy link

+1

application: application,
workers: workers,
syslog: node[:sidekiq][application][:syslog],
environment_variables: OpsWorks::Escape.escape_double_quotes(deploy[:environment_variables]))
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really the main change. The rest is just code clean-up by Atom Beautifier.

@nifuramu
Copy link

+1

1 similar comment
@aadamson
Copy link

+1

@@ -14,7 +14,7 @@
mode "0660"
group deploy[:group]
owner deploy[:user]
variables(:database => deploy[:database], :environment => deploy[:rails_env])
variables(:database => deploy[:database], :environment => deploy[:rails_env], :deploy => deploy)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflict there with PR 2.
#2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like that lines was moved to deploy.rb

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I misread. That line is gone in PR 2.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johncblandii Not sure how you feel about it, but it seems like that commit may not be relevant to this PR?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sorry for the confusion. I pulled both the open PRs into my local and there is a merge conflict when pulling both in. More of a warning for you all.

@interpegasus
Copy link

Hi, I would like to know why sidekiq is not starting automatically?

It works manually after running the following command in the opsworks instance.

$ bundle exec sidekiq -e production &

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants