-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidekiq does not start with environment variables #6
Conversation
👍 Thanks for the shoutout and for offering the change back to the public! |
Absolutely hombre! ;) |
+1 |
application: application, | ||
workers: workers, | ||
syslog: node[:sidekiq][application][:syslog], | ||
environment_variables: OpsWorks::Escape.escape_double_quotes(deploy[:environment_variables])) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really the main change. The rest is just code clean-up by Atom Beautifier.
Switching environment variables to double quotes
+1 |
1 similar comment
+1 |
@@ -14,7 +14,7 @@ | |||
mode "0660" | |||
group deploy[:group] | |||
owner deploy[:user] | |||
variables(:database => deploy[:database], :environment => deploy[:rails_env]) | |||
variables(:database => deploy[:database], :environment => deploy[:rails_env], :deploy => deploy) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge conflict there with PR 2.
#2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like that lines was moved to deploy.rb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, I misread. That line is gone in PR 2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johncblandii Not sure how you feel about it, but it seems like that commit may not be relevant to this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, sorry for the confusion. I pulled both the open PRs into my local and there is a merge conflict when pulling both in. More of a warning for you all.
Hi, I would like to know why sidekiq is not starting automatically? It works manually after running the following command in the opsworks instance. $ bundle exec sidekiq -e production & Thanks |
Two different apps need env vars but they aren't passed with the start command. There may be a better way but this one is tested in two stacks and it works.
Code originally done by @codeodor.