Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle notification exceptions #913

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ochakov
Copy link

@ochakov ochakov commented Nov 26, 2024

Current exception logging throws NPE. Change to Crashlytics log to properly handle these exceptions

PR Type

A better exception handling

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation changes
  • Other... Please describe:

PR Checklist

Please check your PR fulfills the following requirements:

Bugfixes:

  • Regression testing has been carried out using the example project to ensure the intended bug is fixed and no regression bugs have been inadvertently introduced.

New features/enhancements:

  • Exhaustive testing has been carried out for the new functionality
  • Regression testing has been carried out to ensure no existing functionality is adversely affected
  • Documentation has been added / updated
  • The example project has been update to validate/demonstrate the new functionality.

What is the purpose of this PR?

Handle exceptions as in other places of the plugin

Does this PR introduce a breaking change?

  • Yes
  • No

What testing has been done on the changes in the PR?

None as the exception is only visible in logs

What testing has been done on existing functionality?

Other information

Current exception logging throws NPE. Change to Crashlytics log to properly handle these exceptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant