Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMR: move DevVersions jobs to a separate stage #45226

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

akoeplinger
Copy link
Member

@akoeplinger akoeplinger commented Nov 29, 2024

Don't run the validation jobs during the official build.

Fixes dotnet/source-build#4769

Don't run the validation jobs during the official build, we only care about running them in sdk CI.

Fixes dotnet/source-build#4769
@akoeplinger akoeplinger requested review from a team as code owners November 29, 2024 16:56
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Nov 29, 2024
@akoeplinger akoeplinger changed the title VMR: move DevVersions job to a separate stage VMR: move DevVersions jobs to a separate stage Nov 29, 2024
@ViktorHofer
Copy link
Member

we only care about running them in sdk CI

We want to run that in the dotnet/dotnet CI (PRs and rolling builds) as well. Just not in official builds.

@akoeplinger
Copy link
Member Author

akoeplinger commented Nov 29, 2024

ah right, do we have a good property for that? aren't all rolling builds in the VMR "official builds"? or are you talking about public vs internal pipelines?

@ViktorHofer
Copy link
Member

Not sure if we have a property for it. Yes when I said rolling builds, I meant public ones. To be more precise I think these are the configurations when DevLegs should run:

  • Public and internal PRs against dotnet/sdk or dotnet/dotnet
  • Public rolling builds for dotnet/dotnet (which I think includes manually queued builds?) or IOW always in dotnet/dotnet except when performing official builds

@akoeplinger
Copy link
Member Author

akoeplinger commented Dec 2, 2024

@ViktorHofer ok, fixed the conditions

@akoeplinger akoeplinger enabled auto-merge (squash) December 2, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VMR: DevVersions job shouldn't run in the official build
2 participants