Fix failing tests because of "UseUwpTools" property #44859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
marcpopMSFT
approved these changes
Nov 14, 2024
|
Failing tests are already known issue: #44878 Merging on red. |
ViktorHofer
pushed a commit
that referenced
this pull request
Nov 15, 2024
jjonescz
pushed a commit
that referenced
this pull request
Nov 15, 2024
joeloff
pushed a commit
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the UWP .NET 9 tests to disable "UseUwpTools", which otherwise fails to build because of the missing 26100 SDK. Additionally, here we don't want to build UWP libraries anyway, just plain .NET ones. The break is likely caused by the CI image upgrading to VS 17.12, which then brought this change in, which in turn affected the tests. In theory just disabling that opt-out switch should do the trick.
Fixes #44807, #44827