Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Maui Tests #82

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Add Maui Tests #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
179e5cd
Initial checkin for maui tests
mattscheffer Mar 26, 2024
5c72e48
Revert "Initial checkin for maui tests"
mattscheffer Mar 26, 2024
4ff8a32
Initial checkin for maui tests
mattscheffer Mar 26, 2024
6e598f8
Merge branch 'main' into mauiTests
mattscheffer Mar 26, 2024
52b9868
Removing run action for maccatalyst
mattscheffer Mar 27, 2024
07bf8b5
Skipping execution of Maccatalyst if Linux. Maui-desktop workload isn…
mattscheffer Mar 27, 2024
936543a
Skip OSX as maccatalyst on Mac requires xcode
mattscheffer Apr 5, 2024
8c17951
Merge branch 'main' into mauiTests
mattscheffer Apr 5, 2024
b962ee7
Removing commented out test as it wasn't working without additional s…
mattscheffer Apr 8, 2024
cddcd3d
Merge branch 'mauiTests' of https://github.com/mattscheffer/scenario-…
mattscheffer Apr 8, 2024
76765ab
Merge branch 'main' into mauiTests
mattscheffer Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Microsoft.DotNet.ScenarioTests.SdkTemplateTests/DotNetSdkTemplate.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,6 @@ public enum DotNetSdkTemplate
Wpf,
Winforms,
Aspire,
maui,
maccatalyst
}
21 changes: 20 additions & 1 deletion src/Microsoft.DotNet.ScenarioTests.SdkTemplateTests/SdkTemplateTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,6 @@ public void VerifyWorkloadCmd()

[Fact]
[Trait("Category", "Workload")]
[Trait("Category", "InProgress")]
public void VerifyAspireTemplate()
{
var setup = new DotnetWorkloadTest(
Expand All @@ -236,6 +235,26 @@ public void VerifyAspireTemplate()
cleanup.Execute(_sdkHelper, _scenarioTestInput.TestRoot, "aspire");
}

[Fact]
[Trait("Category", "Workload")]
[Trait("SkipIfPlatform", "LINUX")]
[Trait("SkipIfPlatform", "OSX")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these maui tests should pass on Mac?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They surprisingly don't. They fail due to xCode being missing I believe. It might have been a version problem but I don't have the logs on hand to back that up as it's been a few weeks since I tried.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is likely a fixable machine problem, but installing xCode isn't probably something we should be doing as part of this execution I think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's sorta surprising...It should be installed by default (it supports the build tooling).

public void VerifyMaccatalystTemplate()
{
var setup = new DotnetWorkloadTest(
nameof(SdkTemplateTest), _scenarioTestInput.TargetRid,
DotNetSdkActions.WorkloadInstall);
setup.Execute(_sdkHelper, _scenarioTestInput.TestRoot, "maui-desktop");
var newTest = new SdkTemplateTest(
nameof(SdkTemplateTest), DotNetLanguage.CSharp, _scenarioTestInput.TargetRid, DotNetSdkTemplate.maccatalyst,
DotNetSdkActions.Build | DotNetSdkActions.Publish);
newTest.Execute(_sdkHelper, _scenarioTestInput.TestRoot);
var cleanup = new DotnetWorkloadTest(
nameof(SdkTemplateTest), _scenarioTestInput.TargetRid,
DotNetSdkActions.WorkloadUninstall);
cleanup.Execute(_sdkHelper, _scenarioTestInput.TestRoot, "maui-desktop");
}

[Fact]
[Trait("Category", "Offline")]
public void VerifyPreMadeSolution()
Expand Down