-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Editor vertical text alignment not working after toggling IsVisible #26194
Open
NanthiniMahalingam
wants to merge
3
commits into
dotnet:main
Choose a base branch
from
NanthiniMahalingam:fix-25973
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file added
BIN
+25.5 KB
...ts/snapshots/android/VerifyEditorVerticalTextAlignmentWhenVisibilityToggled.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
22 changes: 22 additions & 0 deletions
22
src/Controls/tests/TestCases.HostApp/Issues/Issue25973.xaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
<?xml version="1.0" encoding="utf-8" ?> | ||
<ContentPage xmlns="http://schemas.microsoft.com/dotnet/2021/maui" | ||
xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml" | ||
x:Class="Maui.Controls.Sample.Issues.Issue25973"> | ||
|
||
<ScrollView> | ||
<VerticalStackLayout> | ||
<Editor | ||
x:Name="editor" | ||
AutomationId="Editor" | ||
Text="Editor Text in Vertical End" | ||
IsVisible="False" | ||
VerticalTextAlignment="End" | ||
HeightRequest="100"/> | ||
<Button | ||
x:Name="toggleButton" | ||
AutomationId="ToggleButton" | ||
Text="Change Visibility" | ||
Clicked="VisibilityButtonClicked"/> | ||
</VerticalStackLayout> | ||
</ScrollView> | ||
</ContentPage> |
16 changes: 16 additions & 0 deletions
16
src/Controls/tests/TestCases.HostApp/Issues/Issue25973.xaml.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
namespace Maui.Controls.Sample.Issues | ||
{ | ||
[Issue(IssueTracker.Github, 25973, "Editor vertical text alignment not working after toggling IsVisible", PlatformAffected.UWP)] | ||
public partial class Issue25973 : ContentPage | ||
{ | ||
public Issue25973() | ||
{ | ||
InitializeComponent(); | ||
} | ||
|
||
private void VisibilityButtonClicked(object sender, EventArgs e) | ||
{ | ||
editor.IsVisible = true; | ||
} | ||
} | ||
} |
25 changes: 25 additions & 0 deletions
25
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25973.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
using NUnit.Framework; | ||
using NUnit.Framework.Legacy; | ||
using UITest.Appium; | ||
using UITest.Core; | ||
|
||
namespace Microsoft.Maui.TestCases.Tests.Issues | ||
{ | ||
internal class Issue25973 : _IssuesUITest | ||
{ | ||
public override string Issue => "Editor vertical text alignment not working after toggling IsVisible"; | ||
|
||
public Issue25973(TestDevice device) : base(device) | ||
{ | ||
} | ||
|
||
[Test] | ||
[Category(UITestCategories.Editor)] | ||
public void VerifyEditorVerticalTextAlignmentWhenVisibilityToggled() | ||
{ | ||
App.WaitForElement("ToggleButton"); | ||
App.Click("ToggleButton"); | ||
VerifyScreenshot(); | ||
} | ||
} | ||
} |
Binary file added
BIN
+7.69 KB
...ts/snapshots/windows/VerifyEditorVerticalTextAlignmentWhenVisibilityToggled.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+25.3 KB
....Tests/snapshots/ios/VerifyEditorVerticalTextAlignmentWhenVisibilityToggled.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mnnn, I am concerned about the performance impact. Each invalidation that impacts the size of the control will cause the
VerticalTextAlignment
andDeleteButton
to be updated, which in both cases will look for Descendants or apply changes to the Layout, sometimes without being necessary. For example, a page with several Editors, and resizing the Window will perform the previous updates several times (without being necessary).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jsuarezruiz ,
The Loaded event does not trigger when the Editor visibility changes, which prevents the alignment from being set in this case.
To address this, we used the SizeChanged event instead of the Loaded event. This approach is consistent with the method followed in the Entry control to update properties like VerticalTextAlignment and DeleteButton.
Refer to the Entry code: https://github.com/dotnet/maui/blob/main/src/Core/src/Handlers/Entry/EntryHandler.Windows.cs#L37
As this approach sets the respective native property, such as assigning the VerticalTextAlignment value to the native text box's VerticalAlignment property, we believe that resizing the window will only reapply the same value to the native property. It will not trigger a property change or affect any layout operations.
If you feel this approach is not appropriate for both Entry and Editor, we will explore other alternatives.