Merge branch 'main' into feat-add-support-for-dotnet-9

dotnet · Oct 20, 2024 · 50d95dd · 50d95dd
2 parents c133e74 + 51ac3f9
commit 50d95dd
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -9,7 +9,6 @@ on:
 jobs:
   test:
     runs-on: ${{ matrix.os }}
-    environment: ci
     strategy:
       fail-fast: false
       matrix:

diff --git a/src/Docfx.Dotnet/CompilationHelper.cs b/src/Docfx.Dotnet/CompilationHelper.cs
@@ -179,7 +179,12 @@ void GetReferenceAssembliesCore(PEFile assembly)
                 var file = assemblyResolver.FindAssemblyFile(reference);
                 if (file is null)
                 {
-                    Logger.LogWarning($"Unable to resolve assembly reference {reference}", code: "InvalidAssemblyReference");
+                    // Skip warning for some weired assembly references: https://github.com/dotnet/docfx/issues/9459
+                    if (reference.Version?.ToString() != "0.0.0.0")
+                    {
+                        Logger.LogWarning($"Unable to resolve assembly reference {reference}", code: "InvalidAssemblyReference");
+                    }
+
                     continue;
                 }