-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate tasks in arcade-extensions #507
Comments
Is asking the pipelines that still use these tasks to stop using them an option? |
We can ask them to stop, but we'll probably get more traction making a PR to remove them from the repos ourselves. |
PR to remove dead code from dotnet/arcade-extensions: dotnet/arcade-extensions#75 |
PR to deprecate Telemetry API in Helix: https://dnceng.visualstudio.com/internal/_git/dotnet-helix-service/pullrequest/32995 |
PRs for other repos: |
PRs submitted to internal repos; email sent to Partners alerting folks of the total deprecation. Will aim to merge all deprecation PRs at the end of Aug 2023. |
PR to remove to the tasks was merged. The extensions were updated on the AzDO marketplace. Closing this issue. |
Context
Even though "no one is using" the Azure DevOps tasks anymore, the code still exists in the arcade-extensions repo, and thus, must be maintained per CG rules. To eliminate the need for this maintenance, we should delete the code for the tasks and be clear about the deprecation of the API (for future devs to not have to do the same exercise of figuring out why the methods are a no-op).
Note: The tasks are still a part of servicing branches, so they will continue to "be used" by those branches, but are not used by any current branches
Historical Context
The SendStartTelemetry and SendEndTelemetry tasks eventually feed data into the Telemetry API in Helix API. However, all the methods in the Telemetry API are no-ops since circa 2018. These tasks, along with BashOrCmd, were created 5+ years ago to fill a need that wasn't available in Azure DevOps at the time. Since then, the product teams have moved to using functionality in Azure DevOps, thus, there is no longer a need to maintain these tasks.
Action Items
Add alerting to Grafana that looks and alerts on usage of the Telemetry API so that we can track down other places that need to have the task removed.Opting to remove everything, so no need to track who's calling itRelease Note Category
Release Note Description
The text was updated successfully, but these errors were encountered: