Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve distributed transactions on pooled connection reset #3019

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mdaigle
Copy link
Contributor

@mdaigle mdaigle commented Nov 18, 2024

The current behavior only preserves transaction state for the root transaction. Enlisted connections that are reset will be placed in the transacted connection pool, but in some situations, will no longer participate in the transaction. The next connection to request the connection will expect it to be participating in the transaction, but actions on the connection will auto-commit.

This changes the reset logic to preserve transaction state for enlisted connections (part of a distributed transaction, but not root).

@mdaigle
Copy link
Contributor Author

mdaigle commented Nov 18, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mdaigle mdaigle changed the title Preserve distributed transactions on connection reset Preserve distributed transactions on pooled connection reset Nov 18, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.69%. Comparing base (b1f7eaf) to head (6db966b).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3019   +/-   ##
=======================================
  Coverage   72.68%   72.69%           
=======================================
  Files         285      285           
  Lines       59155    59161    +6     
=======================================
+ Hits        42998    43005    +7     
+ Misses      16157    16156    -1     
Flag Coverage Δ
addons 92.58% <ø> (ø)
netcore 75.40% <100.00%> (+0.01%) ⬆️
netfx 71.13% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mdaigle mdaigle marked this pull request as ready for review November 20, 2024 17:17
@mdaigle mdaigle linked an issue Nov 20, 2024 that may be closed by this pull request
@mdaigle mdaigle added the 🐛 Bug! Issues that are bugs in the drivers we maintain. label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug! Issues that are bugs in the drivers we maintain.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure SQL DTC bug
1 participant