Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge | Align TdsExecuteRPC between netcore and netfx #2985

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

MichelZ
Copy link
Contributor

@MichelZ MichelZ commented Nov 7, 2024

Splitting up TdsExecuteRPC to multiple functions to align netcore and netfx

Part of #2953

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 82.32558% with 38 lines in your changes missing coverage. Please review.

Project coverage is 72.65%. Comparing base (b9877f4) to head (b589f11).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs 82.15% 38 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2985       +/-   ##
===========================================
- Coverage   92.58%   72.65%   -19.93%     
===========================================
  Files           6      285      +279     
  Lines         310    59198    +58888     
===========================================
+ Hits          287    43013    +42726     
- Misses         23    16185    +16162     
Flag Coverage Δ
addons 92.58% <ø> (ø)
netcore 75.46% <100.00%> (?)
netfx 71.04% <82.15%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichelZ MichelZ changed the title Align TdsExecuteRPC between netcore and netfx Merge | Align TdsExecuteRPC between netcore and netfx Nov 24, 2024
@mdaigle mdaigle added the Common Project 🚮 Things that relate to the common project project label Nov 25, 2024
Copy link
Contributor

@benrr101 benrr101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's get the conflicts resolved so we can verify CI

@MichelZ MichelZ closed this Nov 26, 2024
@MichelZ MichelZ force-pushed the merge-tdsparser-tdsexecuterpc branch from 1691c1b to 8c15c00 Compare November 26, 2024 05:52
@MichelZ MichelZ reopened this Nov 26, 2024
@MichelZ
Copy link
Contributor Author

MichelZ commented Nov 26, 2024

I've re-applied the changes on current main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Common Project 🚮 Things that relate to the common project project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants