Kill all escapes #4888
Merged
Kill all escapes #4888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gewarren can you take a quick look and weigh on whether this looks right? This is just to stop using cryptic escape sequences when referencing APIs from |
gewarren
approved these changes
Nov 22, 2024
|
I took a brief look and it looks right, plus the build would catch any errors. BTW, a few of us wrote an extension for inserting xref links that makes it very easy - see https://github.com/IEvangelist/xref-helper. |
|
Thanks @gewarren, that extension looks great! @dotnet/efteam can someone please approve as well? |
AndriySvyryd
approved these changes
Nov 25, 2024
roji
force-pushed
the
KillAllEscapes
branch
2 times, most recently
from
2e206a5
to
b0cf689
Compare
%2A -> * %60 -> `
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on top of #4887, review 2nd commit only.